From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 1D3BF1FF15E for <inbox@lore.proxmox.com>; Tue, 8 Apr 2025 10:54:04 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 2BD93EC60; Tue, 8 Apr 2025 10:54:01 +0200 (CEST) Message-ID: <22c4b422-f443-4dbb-ab67-b1a793f0fed9@proxmox.com> Date: Tue, 8 Apr 2025 10:53:27 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Thomas Lamprecht <t.lamprecht@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20250407101310.3196974-1-d.csapak@proxmox.com> <20250407101310.3196974-6-d.csapak@proxmox.com> <1b3cd284-9345-4fcd-ad3a-e7ac874f7548@proxmox.com> <46ea2449-c2a2-49bd-8215-b4603c5cb87f@proxmox.com> <75b57ca6-71e1-4424-bba4-5529d3689532@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <75b57ca6-71e1-4424-bba4-5529d3689532@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.022 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH manager v6 3/4] ui: qemu hd edit: allow importing a disk from the import storage X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 4/8/25 10:40, Thomas Lamprecht wrote: > Am 08.04.25 um 09:01 schrieb Dominik Csapak: >> On 4/8/25 00:13, Thomas Lamprecht wrote: >>> Am 07.04.25 um 12:13 schrieb Dominik Csapak: >>>> adds a checkbox 'import image' above the storage selector which: >>>> * hides the original storage selector >>>> * shows a 'source storage' selector >>>> * shows a 'import file' selector >>>> * shows a 'target storage' selector >>>> >>>> Since the wizard and the hd edit share this panel, this also works in >>>> the wizard. >>> >>> Can we disable this for HD Add? IMO that dialogue is already really >>> complex as is. >>> >>> Might be even beneficial if this is always predefined from the call >>> or integration side... >>> >>> And seems I cannot start an import through the import storage content >>> view? Feels odd to me, all other imports are triggered there after all. >> >> ok so if I understand you correctly, you want this in the wizard but not >> in the 'add hd' panel ? And you want to have a (probably simplified) hd >> add panel from the import storage content panel directly ? > > Yeah for starters I'd probably just have gone for allowing importing > such a disk to an existing VM. That said checking a few reports and > rethinking this users might actually want to have it available in the > creation process, that feels a bit more natural... > > Cc'in Aaron for an opinion as he often gets UX feedback a bit more > directly in trainings and has a more decisive opinion on these > things. what i currently have (half) working here is basically what i wrote below, the same input panel, but either for creating a new disk or importing, and the caller decides. with another button in the wizard that allows adding such an 'import panel' (should be relatively easy to add that to the hardware panel and import storage content too) > >> >> sounds fine to me, an alternative I could offer would be to >> have a separate input panel only for importing, and show in the wizard >> another button (e.g. split button on add) that adds that import panel >> and for the guests a new entry in the 'add menu' that says 'import' >> >> (this panel could then also be added to the import storage content, >> with an additional vm selector) > > btw: should this have a fix #2424 ? you're right, at least a 'partially fixes #2424' since the users also wanted to have definitions uploaded (libvirt xmls?) but not sure if that's even a thing that we want to have.. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel