From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 94AC562D1D for ; Fri, 18 Sep 2020 12:01:37 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 5504514E42 for ; Fri, 18 Sep 2020 12:01:07 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 21ACC14E32 for ; Fri, 18 Sep 2020 12:01:06 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id DB1D54542D for ; Fri, 18 Sep 2020 12:01:05 +0200 (CEST) To: Proxmox VE development discussion , Stoiko Ivanov References: <20200917191701.2236-1-s.ivanov@proxmox.com> <20200917191701.2236-2-s.ivanov@proxmox.com> From: Thomas Lamprecht Message-ID: <228f90ec-5850-379d-d4e4-da2e57e45c83@proxmox.com> Date: Fri, 18 Sep 2020 12:01:03 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:81.0) Gecko/20100101 Thunderbird/81.0 MIME-Version: 1.0 In-Reply-To: <20200917191701.2236-2-s.ivanov@proxmox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.195 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [tools.pm] Subject: [pve-devel] applied: Re: [PATCH common 1/1] sync_mountpoint: open path so that sync works X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 18 Sep 2020 10:01:37 -0000 On 9/17/20 9:17 PM, Stoiko Ivanov wrote: > sync_mountpoint takes a path, gets an open filedescriptor and calls > syncfs(2) on it. > by opening with O_PATH the syncfs call fails with EBADF (see open(2)). > > found by running: > ``` > pkill -f 'pvedaemon worker'; > strace -yyttT -s 512 -o /tmp/trace -fp $(pgrep -f pvedaemon$) > ``` > > Signed-off-by: Stoiko Ivanov > --- > src/PVE/Tools.pm | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > applied, thanks! Followed up with a change in error propagation, after checking the call sites (which is only one). diff --git a/src/PVE/Tools.pm b/src/PVE/Tools.pm index 7eb1197..7d33683 100644 --- a/src/PVE/Tools.pm +++ b/src/PVE/Tools.pm @@ -1434,9 +1434,12 @@ sub fsync($) { sub sync_mountpoint { my ($path) = @_; sysopen my $fd, $path, O_RDONLY|O_CLOEXEC or die "failed to open $path: $!\n"; - my $result = syncfs(fileno($fd)); + my $syncfs_err; + if (!syncfs(fileno($fd))) { + $syncfs_err = "$!"; + } close($fd); - return $result; + die "syncfs '$path' failed - $syncfs_err\n" if defined $syncfs_err; } # support sending multi-part mail messages with a text and or a HTML part