From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 0831574BBB for ; Tue, 22 Jun 2021 14:11:20 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id F1A7C26E92 for ; Tue, 22 Jun 2021 14:11:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 4EBAA26E6F for ; Tue, 22 Jun 2021 14:11:19 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 15C4B443B4 for ; Tue, 22 Jun 2021 14:11:19 +0200 (CEST) Message-ID: <227f26df-2026-9229-f7fb-eaf3e346fa71@proxmox.com> Date: Tue, 22 Jun 2021 14:11:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:90.0) Gecko/20100101 Thunderbird/90.0 Content-Language: en-US To: Proxmox VE development discussion , Dominik Csapak References: <20210622095725.27282-1-d.csapak@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210622095725.27282-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.697 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH widget-toolkit] panel/JournalView: fix flickering in journal livemode X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 12:11:20 -0000 On 22.06.21 11:57, Dominik Csapak wrote: > it seems that something changed in extjs 7 which does not quite > restore the correct scroll position when the identical content is set > on a component. this means that sometimes, we update the text > with the identical one, but the scroll position is now off, only > to scroll back to the bottom > > this causes a flickering everytime we do the api call. > > instead, only update the component when the content really changed. > > Signed-off-by: Dominik Csapak > --- > src/panel/JournalView.js | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > applied, thanks!