From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id ECFC91FF2D6 for ; Mon, 22 Jul 2024 19:51:59 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 0035E377F0; Mon, 22 Jul 2024 19:52:33 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; t=1721669822; cv=none; d=zohomail.com; s=zohoarc; b=SyVVv4QOEWPtwlX68duaA6dCqsSzVOLhwoL7FwcSTIQ9N33zxpay/eECSu5xOXoNGu3ryFAN4g4l5mjVVJKiX3i9weWwEBoKo/L1NlmqRkrMmBQs4LUe7PUGjZQBzWUXpKSXXNMHqG4vYNy+TIGyp1VY6rQGD+lq3CPrEvgUFL8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1721669822; h=Content-Type:Content-Transfer-Encoding:Date:Date:From:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:Subject:To:To:Message-Id:Reply-To:Cc; bh=DHCalQ6hnn9O43U1GEA0E8KdjneZEsiXEVrICb5QZ14=; b=MZgXfJ0zZTDvuq7BIz5CfMxXFyua+r/o/XhFs00GyZdDVDM8UzErTBUJs2AAc7CuND3qA3k3L2Bd/9o8QTOG13+i7iSoJXkg7BsUSGMIkUjZHUNfIlpDMNSyi6iw4ekaFp6E9knY6fbyjjp8K2NkLuCEkpBlUa5hM0j1Eee7DPo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=lamprecht.org; spf=pass smtp.mailfrom=thomas@lamprecht.org; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1721669822; s=zoho; d=lamprecht.org; i=thomas@lamprecht.org; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To:Cc; bh=DHCalQ6hnn9O43U1GEA0E8KdjneZEsiXEVrICb5QZ14=; b=WH3+38xz94JbUPHTXvUtoDln+ALGrN17UJfS7J2W7SYdCgtUyHElyyjLUVp9pblP 80s+CQKS/JIY/iYsGlir+xAClBVKCkDP7PmcIdcQQdw/tJEpufg+ARXBSS1ISKBavsv vjDXxI2OLJFmIhKpBJ5noV1rOA3xqTIw0fyjGN5Y= Message-ID: <22716cc9-03f0-4be7-b85f-1c1fe3f736d7@lamprecht.org> Date: Mon, 22 Jul 2024 19:36:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Proxmox VE development discussion , Lukas Wagner References: <20240708093812.164901-1-l.wagner@proxmox.com> Content-Language: en-GB, de-AT From: Thomas Lamprecht In-Reply-To: <20240708093812.164901-1-l.wagner@proxmox.com> X-ZohoMailClient: External X-SPAM-LEVEL: Spam detection results: 0 ARC_SIGNED 0.001 Message has a ARC signature ARC_VALID 0.001 Message has a valid ARC signature BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_MISSING 0.1 Missing DMARC policy RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust RCVD_IN_MSPIKE_H4 0.001 Very Good reputation (+4) RCVD_IN_MSPIKE_WL 0.001 Mailspike good senders SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] partially-applied: [PATCH many v9 00/13] notifications: notification metadata matching improvements X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 08/07/2024 um 11:37 schrieb Lukas Wagner: > This patch series attempts to improve the user experience when creating > notification matchers. > > Some of the noteworthy changes: > - Allow setting a custom backup job ID, similar how we handle it for > sync/prune jobs in PBS (to allow recognizable names used in matchers) > - New metadata fields: > - job-id: Job ID for backup-jobs or replication-jobs > - Add an API that enumerates known notification metadata fields/values > - Suggest known fields/values in match rule window > - Some code clean up for match rule edit window > - Extended the 'exact' match-field mode - it now allows setting multiple > allowed values, separated via ',': > e.g. `match-field exact:type=replication,fencing > Originally, I created a separate 'list' match type for this, but > since the semantics for a list with one value and 'exact' mode > are identical, I decided to just extend 'exact'. > This is a safe change since there are are no values where a ',' > makes any sense (config IDs, hostnames) > > NOTE: Might need a versionened break, since the widget-toolkit-patches > depend on new APIs provided by pve-manager. If the API is not present, > creating matchers with 'match-field' does not work (cannot load lists > of known values/fields) > > Inter-Dependencies: > - the widget-toolkit dep in pve-manager needs to be bumped > to at least 4.1.4 > (we need "utils: add mechanism to add and override translatable notification event > descriptions in the product specific UIs", otherwise the UI breaks > with the pve-manager patches applied) --> already included a patch for > this > - widget-toolkit relies on a new API endpoint provided by pve-manager: > --> we require a versioned break in widget-toolkit on pve-manager not sure if I really want to do that as it's not really useful for clusters anyway, where the loaded wtk can be newer than the manager of a (proxied) node. But in any way: many thanks for mentioning it. > - pve-manager needs bumped pve-guest-common (thx @Fabian) > > Changelog: > - v9: fix typos in commit message, add @Max's R-b trailer - thx! > - v8: incorporate feedback from @Fabian, thx a lot! > - Made 'job-id' API param usable by root@pam only - this should prevent > abuse by spoofing job-id, potentially bothering other users with bogus > notifications. > - Don't set 'job-id' when starting a backup job via 'Run now' in the UI > - Add a note to the docs explaining when job-id is set and when not. > - Drop already applied patches > - v7: incorporated some more feedback from @Fiona, thx! > - Fixed error when switching from 'exact' to 'regex' if the text field > was empty > - rebased to latest master > - 'backport' doc improvements from PBS > - bumped widget-toolkit dep > - v6: incorporate feedback from @Fiona, thx! > - rename 'id' -> 'job-id' in VZDump API handler > - consolidate 'replication-job'/'backup-job' to 'job-id' > - Move 'job-id' setting to advanced tab in backup job edit. > - Don't use 'internal' flag to mark translatable fields, since > the only field where that's necessary is 'type' for now - so > just add a hardcoded check > - v5: > - Rebased onto latest master, resolving some small conflict > - v4: > - widget-toolkit: break out changes for the utils module so that they > can be applied ahead of time to ease dep bumping > - don't show Job IDs in the backup/replication job columns > - v3: > - Drop already applied patches for `proxmox` > - Rebase onto latest master - minor conflict resolution was needed > - v2: > - include 'type' metadata field for forwarded mails > --> otherwise it's not possible to match them > - include Maximilliano's T-b trailer in UI patches > > pve-guest-common: > > Lukas Wagner (1): > vzdump: common: allow 'job-id' as a parameter without being in schema > > src/PVE/VZDump/Common.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > pve-manager: > > Lukas Wagner (5): > api: jobs: vzdump: pass job 'job-id' parameter > ui: dc: backup: allow to set custom job id in advanced settings > api: notification: add API for getting known metadata fields/values > ui: utils: add overrides for translatable notification fields/values > d/control: bump proxmox-widget-toolkit dependency to 4.1.4 > > PVE/API2/Backup.pm | 2 +- > PVE/API2/Cluster/Notifications.pm | 139 ++++++++++++++++++++ > PVE/API2/VZDump.pm | 13 +- > PVE/Jobs/VZDump.pm | 4 +- > PVE/VZDump.pm | 6 +- > debian/control | 2 +- > www/manager6/Utils.js | 11 ++ > www/manager6/dc/Backup.js | 4 - > www/manager6/panel/BackupAdvancedOptions.js | 23 ++++ > 9 files changed, 192 insertions(+), 12 deletions(-) > applied above for now, we probably should bump manager soonish and then can apply below. > > proxmox-widget-toolkit: > > Lukas Wagner (4): > notification: matcher: match-field: show known fields/values > notification: matcher: move match-field formulas to local viewModel > notification: matcher: move match-calendar fields to panel > notification: matcher: move match-severity fields to panel > > src/data/model/NotificationConfig.js | 12 + > src/window/NotificationMatcherEdit.js | 613 ++++++++++++++++++-------- > 2 files changed, 441 insertions(+), 184 deletions(-) > > > pve-docs: > > Lukas Wagner (3): > notifications: describe new notification metadata fields > notifications: match-field 'exact'-mode can now match multiple values > notifications: add note regarding when 'job-id' is set for backups > > notifications.adoc | 42 +++++++++++++++++++++--------------------- > 1 file changed, 21 insertions(+), 21 deletions(-) > > > Summary over all repositories: > 13 files changed, 655 insertions(+), 218 deletions(-) > _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel