From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <t.lamprecht@proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by lists.proxmox.com (Postfix) with ESMTPS id E437E96568
 for <pve-devel@lists.proxmox.com>; Tue, 24 Jan 2023 16:30:04 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
 by firstgate.proxmox.com (Proxmox) with ESMTP id CCF216030
 for <pve-devel@lists.proxmox.com>; Tue, 24 Jan 2023 16:30:04 +0100 (CET)
Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com
 [94.136.29.106])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits))
 (No client certificate requested)
 by firstgate.proxmox.com (Proxmox) with ESMTPS
 for <pve-devel@lists.proxmox.com>; Tue, 24 Jan 2023 16:30:04 +0100 (CET)
Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1])
 by proxmox-new.maurer-it.com (Proxmox) with ESMTP id CF30245EBF
 for <pve-devel@lists.proxmox.com>; Tue, 24 Jan 2023 16:30:03 +0100 (CET)
Message-ID: <225a50b5-2326-7205-1eab-a9cbd0b16fdd@proxmox.com>
Date: Tue, 24 Jan 2023 16:30:03 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101
 Thunderbird/109.0
Content-Language: en-GB
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
 Lukas Wagner <l.wagner@proxmox.com>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
References: <20230123131735.400368-1-l.wagner@proxmox.com>
 <20230123131735.400368-2-l.wagner@proxmox.com>
 <5d124158-1ce3-81b9-e1cd-60f4bc20b894@proxmox.com>
In-Reply-To: <5d124158-1ce3-81b9-e1cd-60f4bc20b894@proxmox.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
X-SPAM-LEVEL: Spam detection results:  0
 AWL 3.031 Adjusted score from AWL reputation of From: address
 BAYES_00                 -1.9 Bayes spam probability is 0 to 1%
 KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
 NICE_REPLY_A           -1.148 Looks like a legit reply (A)
 RCVD_IN_DNSWL_HI           -5 Sender listed at https://www.dnswl.org/,
 high trust
 SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
 SPF_PASS               -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [PATCH v2 widget-toolkit 1/1] repo view: replace
 non-clickable checkbox with icons
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, 
 <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
X-List-Received-Date: Tue, 24 Jan 2023 15:30:04 -0000

Am 24/01/2023 um 16:24 schrieb Thomas Lamprecht:
>> -	    dataIndex: 'Enabled',
>> -	    listeners: {
>> -		beforecheckchange: () => false, // veto, we don't want to allow inline change - to subtle
>> +	    dataindex: 'Enabled',
>> +	    align: 'center',
>> +	    renderer: function(enabled, cell, record) {
>> +		return Proxmox.Utils.render_enabled_icon(record.data.Enabled);
>>  	    },
> could be a one liner without losing clarity:
> 
> renderer: ({data}) => Proxmox.Utils.renderEnabledIcon(data.Enabled),
> 

Actually, as in my reply to 2/2, you break setting dataIndex by writing it
all lowercase, as otherwise you should be able to configure the renderer
function directly, without intermediate call