From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68])
by lore.proxmox.com (Postfix) with ESMTPS id 3FE0E1FF16B
for <inbox@lore.proxmox.com>; Thu, 6 Feb 2025 15:05:58 +0100 (CET)
Received: from firstgate.proxmox.com (localhost [127.0.0.1])
by firstgate.proxmox.com (Proxmox) with ESMTP id 5405E2839F;
Thu, 6 Feb 2025 15:05:55 +0100 (CET)
Message-ID: <21d31eb7-60d7-46e0-8497-fd93f56574e2@proxmox.com>
Date: Thu, 6 Feb 2025 15:05:51 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Max Carrara <m.carrara@proxmox.com>,
Wolfgang Bumiller <w.bumiller@proxmox.com>
References: <20250130145124.317745-1-m.carrara@proxmox.com>
<7pmkq3by7xrcxr6wku6wvrpoa52xi3q7k5br2ztkwmmvhggyxz@h3vx353ekvky>
<D7KM46BDB9EW.SJLPO4401I9E@proxmox.com>
Content-Language: en-US
From: Fiona Ebner <f.ebner@proxmox.com>
In-Reply-To: <D7KM46BDB9EW.SJLPO4401I9E@proxmox.com>
X-SPAM-LEVEL: Spam detection results: 0
AWL -0.047 Adjusted score from AWL reputation of From: address
BAYES_00 -1.9 Bayes spam probability is 0 to 1%
DMARC_MISSING 0.1 Missing DMARC policy
KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment
RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to
Validity was blocked. See
https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more
information.
SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record
SPF_PASS -0.001 SPF: sender matches SPF record
Subject: Re: [pve-devel] [RFC v1 pve-storage 0/6] RFC: Tighter API Control
for Storage Plugins
X-BeenThere: pve-devel@lists.proxmox.com
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe>
List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>,
<mailto:pve-devel-request@lists.proxmox.com?subject=subscribe>
Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: pve-devel-bounces@lists.proxmox.com
Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Am 05.02.25 um 16:20 schrieb Max Carrara:
> On Wed Feb 5, 2025 at 12:17 PM CET, Wolfgang Bumiller wrote:
>> I don't think accidentally-public private helpers should be considered
>> part of the API. We can just deprecate them immediately, remove them
>> "soon". They aren't part of the `PVE::Storage`<->`Plugin` surface after
>> all.
>
> Hmm, fair. I wasn't sure what our stance on that exactly is, so I
> dediced to be conservative here; as in: "If it's being used by someone
> else, then it's already part of an API", if that makes sense.
>
> Though, since we're fine with removing them, I'll just migrate them soon
> and provide wrappers that emit a warning (or something) in case any
> third-party modules are still using them. Once we do a major / minor
> bump of PVE, we can remove the wrappers while not touching the storage
> API{VER,AGE} (at least not for those helpers specifically).
I'd also err on the side of caution here. We never explicitly documented
what is and isn't part of the plugin API, so chances are that some
external plugins do make use of some such helpers. Removing them during
a minor release or without APIAGE reset will not be nice to plugin
authors. We'll likely do an APIAGE reset for PVE 9 in any case, so we
could just do the breaking change for such helpers then too.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel