From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 890631FF168 for ; Tue, 12 Nov 2024 11:19:58 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 36C1F1D0AD; Tue, 12 Nov 2024 11:19:56 +0100 (CET) Message-ID: <21c41028-601d-4e28-bea7-cd621431c7ff@proxmox.com> Date: Tue, 12 Nov 2024 11:19:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Thomas Lamprecht , Proxmox VE development discussion References: <20241107165146.125935-1-f.ebner@proxmox.com> <20241107165146.125935-11-f.ebner@proxmox.com> <0bb0e050-cde8-4471-86d5-4154afd447eb@proxmox.com> Content-Language: en-GB From: Fiona Ebner In-Reply-To: <0bb0e050-cde8-4471-86d5-4154afd447eb@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [RFC common v3 10/34] env: add module with helpers to run a Perl subroutine in a user namespace X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" On 11.11.24 7:33 PM, Thomas Lamprecht wrote: > Am 07.11.24 um 17:51 schrieb Fiona Ebner: >> +package PVE::Env; > > can this module and it's name be more specific to doing stuff with/in namespaces? > > e.g. PVE::Namespaces or PVE::Sys::Namespaces (there might be other stuff that might > fit well in a future libproxmox-sys-perl and Proxmox::Sys::* respectively, so > maybe that module path would be better?) > > I'd also make all sub's private if not really intended to be used outside > this module. > Will do! > If the more general fork/wait-child helpers are needed elsewhere, or deemed > to be useful, then they could go in their own module, like e.g. PVE::Sys::Process > Since you already pointed out a potential user, will go for this too. >> +sub forked(&%) { > > FWIW, there's some "forked" method in test/lock_file.pl that this might replace too, > if it stay public. > I'll check if it can be adapted easily. _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel