From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <pve-devel-bounces@lists.proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 364B51FF15F for <inbox@lore.proxmox.com>; Mon, 18 Nov 2024 14:44:52 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id B3177110F4; Mon, 18 Nov 2024 14:44:55 +0100 (CET) Message-ID: <21c1cac9-3e70-4b37-9767-d5cc160c9ca9@proxmox.com> Date: Mon, 18 Nov 2024 14:44:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Beta To: Lukas Wagner <l.wagner@proxmox.com>, Proxmox VE development discussion <pve-devel@lists.proxmox.com> References: <20241115151749.633407-1-d.csapak@proxmox.com> <D5PBS0NDDO22.3ENLUV15D4DG4@proxmox.com> <6efce1fc-0e03-4966-ac3a-ee433f2acc01@proxmox.com> <D5PCHKPRRKZC.335GKK7ESX61O@proxmox.com> Content-Language: en-US From: Dominik Csapak <d.csapak@proxmox.com> In-Reply-To: <D5PCHKPRRKZC.335GKK7ESX61O@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL 0.016 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_VALIDITY_CERTIFIED_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_RPBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. RCVD_IN_VALIDITY_SAFE_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to Validity was blocked. See https://knowledge.validity.com/hc/en-us/articles/20961730681243 for more information. SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH storage/qemu-server/manager v6] implement ova/ovf import for file based storages X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> Reply-To: Proxmox VE development discussion <pve-devel@lists.proxmox.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" <pve-devel-bounces@lists.proxmox.com> On 11/18/24 14:39, Lukas Wagner wrote: > On Mon Nov 18, 2024 at 2:18 PM CET, Dominik Csapak wrote: >> On 11/18/24 14:06, Lukas Wagner wrote: >>> On Fri Nov 15, 2024 at 4:17 PM CET, Dominik Csapak wrote: >>>> This series enables importing ova/ovf from directory based storages, >>>> inclusive upload/download via the webui (ova only). >>>> >>>> It also improves the ovf importer by parsing the ostype, nics, bootorder >>>> (and firmware from vmware exported files). >>>> >>>> I opted to move the OVF.pm to pve-storage, since there is no >>>> real other place where we could put it. I put it in a new module >>>> 'GuestImport' >>>> >>>> We now extract the images into either a given target storage or in the >>>> import storage in the 'images' dir so accidentally left over images >>>> are discoverable by the ui/cli. >>>> >>>> This version is half rebased on fabians hardening series: >>>> https://lore.proxmox.com/pve-devel/20241104104221.228730-1-f.gruenbichler@proxmox.com/ >>>> >>>> I sent the qemu-server patch from fabian again but omitted some >>>> problematic checks. I add them later with a check >>>> against the import vtype again (last patch in qemu-server) >>> >>> Hi, >>> gave this series a quick test on the respective latest master branches. >>> >>> Looking good so far, but a couple of things that I've noticed were: >>> - In the UI, checking 'Live Import' does not seem to have any effect >>> (is live import even available for OVA import?) >> >> yes this works here, under what condition does it not for you? >> > > nothing special, I tested the feature using the Home Assistant .ova from > [1]. Downloaded the OVA to my local storage, pressed "import", did not > change *any* settings apart from ticking "live import". > The import works, but the VM is not started. Starting the VM manually > works fine, also the tasks log does not show anything of concern. > In the browser network requests I saw that 'live-restore' is set to '1' > in the import POST request. > > [1] https://www.home-assistant.io/installation/alternative/ mhmm can reproduce with that ova image, maybe it has something to do with our ovf import not detecting the main disk? (at least here it does not detect any disk) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel