From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <t.lamprecht@proxmox.com> Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 4B8E995868 for <pve-devel@lists.proxmox.com>; Wed, 18 Jan 2023 16:08:35 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 3090022402 for <pve-devel@lists.proxmox.com>; Wed, 18 Jan 2023 16:08:35 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for <pve-devel@lists.proxmox.com>; Wed, 18 Jan 2023 16:08:34 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id C40DA448F8 for <pve-devel@lists.proxmox.com>; Wed, 18 Jan 2023 16:08:33 +0100 (CET) Message-ID: <2173aeee-90d7-3054-27c8-17711f4ffcc3@proxmox.com> Date: Wed, 18 Jan 2023 16:08:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-GB To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>, Dominik Csapak <d.csapak@proxmox.com> References: <20230118131303.2892050-1-d.csapak@proxmox.com> From: Thomas Lamprecht <t.lamprecht@proxmox.com> In-Reply-To: <20230118131303.2892050-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.037 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied-series: [PATCH widget-toolkit/pve-manager] move node selection into combogrid X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com> List-Unsubscribe: <https://lists.proxmox.com/cgi-bin/mailman/options/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=unsubscribe> List-Archive: <http://lists.proxmox.com/pipermail/pve-devel/> List-Post: <mailto:pve-devel@lists.proxmox.com> List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help> List-Subscribe: <https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel>, <mailto:pve-devel-request@lists.proxmox.com?subject=subscribe> X-List-Received-Date: Wed, 18 Jan 2023 15:08:35 -0000 Am 18/01/2023 um 14:12 schrieb Dominik Csapak: > proxmox-widget-toolkit: > > Dominik Csapak (2): > ComboGrid: use the grids view for the error message > ComboGrid: make height for the error configurable > > src/form/ComboGrid.js | 14 +++++++++----- > 1 file changed, 9 insertions(+), 5 deletions(-) > > pve-manager: > > Dominik Csapak (6): > ui: StorageScanNodeSelector: use null as empty value > ui: storage: move node scan selector inside combobox > ui: storage/LvmThinInputPanel: modernize & cleanup code > ui: storage/IScsiInputPanel: modernize, cleanup & improve panel > ui: storage/ZFSPoolInputPanel: modernize & cleanup code > ui: storage/LVMInputPanel: modernize & cleanup code > > www/manager6/form/ComboBoxSetStoreNode.js | 45 +++- > www/manager6/form/StorageScanNodeSelector.js | 8 +- > www/manager6/storage/IScsiEdit.js | 129 +++++++----- > www/manager6/storage/LVMEdit.js | 209 +++++++++++-------- > www/manager6/storage/LvmThinEdit.js | 150 +++++++------ > www/manager6/storage/ZFSPoolEdit.js | 100 +++++---- > 6 files changed, 361 insertions(+), 280 deletions(-) > nice! applied series with touching up some commit message (subjects) slightly to my (opinionated) liking, thanks! as mentioned off-list: currently the outer/main picker is closed unexpected when: - one wants to close the nested/inner one by clicking somewhere in the outer one. - the node-selection input field of the nested-picker has focus and one clicks somewhere in the outer/main picker. It's not a big thing, but otoh: it *is* slightly irritating..