From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 1492860790 for ; Thu, 26 Nov 2020 11:00:29 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 12CD6DC3F for ; Thu, 26 Nov 2020 11:00:29 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id 1ACB6DBDE for ; Thu, 26 Nov 2020 11:00:28 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id D50C145C3D for ; Thu, 26 Nov 2020 11:00:27 +0100 (CET) To: Proxmox VE development discussion , Dominik Csapak References: <20201126075825.11727-1-d.csapak@proxmox.com> From: Thomas Lamprecht Message-ID: <20c9d41f-295d-4fed-0c97-f92847ea3089@proxmox.com> Date: Thu, 26 Nov 2020 11:00:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:83.0) Gecko/20100101 Thunderbird/83.0 MIME-Version: 1.0 In-Reply-To: <20201126075825.11727-1-d.csapak@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.078 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH manager] ui: storage: find the correct storage record X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Nov 2020 10:00:29 -0000 On 26.11.20 08:58, Dominik Csapak wrote: > by default, findRecord only anchors at the beginning, e.g. > findRecord('id', 'foo'); > could find either an entry with id 'foo', 'foobar', 'foobaz', etc. > > extend the call to set 'exactMatch' to true, else we sometimes > used the content types of storage e.g., 'local-lvm' for showing > the panels for 'local' > > Signed-off-by: Dominik Csapak > --- > this is the most stupid interface i could imagine for something > called 'findRecord'... i'll go ahead and check where we use this, > and try to see if we need to change it there as well... > > www/manager6/storage/Browser.js | 4 ++++ > 1 file changed, 4 insertions(+) > > applied, thanks!