From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [IPv6:2a01:7e0:0:424::9]) by lore.proxmox.com (Postfix) with ESMTPS id 0E2AA1FF2CF for ; Thu, 11 Jul 2024 13:23:26 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 15FA83219A; Thu, 11 Jul 2024 13:23:48 +0200 (CEST) Message-ID: <20a9b421-7ba2-4bc2-88ca-b569c70fbb3f@proxmox.com> Date: Thu, 11 Jul 2024 13:23:12 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Aaron Lauterer , pve-devel@lists.proxmox.com References: <20240711111102.1184202-1-a.lauterer@proxmox.com> Content-Language: en-US From: Fiona Ebner In-Reply-To: <20240711111102.1184202-1-a.lauterer@proxmox.com> X-SPAM-LEVEL: Spam detection results: 0 AWL -0.062 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH docs] vzdump: fleecing: rephrase manual vzdump example X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" Am 11.07.24 um 13:11 schrieb Aaron Lauterer: > Signed-off-by: Aaron Lauterer > --- > @fiona please let me know if this works and doesn't introduce wrong > infos. > I think this way the sentence represents better what is happening, as > it is not enabling it, but running that particular backup with fleecing. > > I am also thinking of placing the actual command of this and the now > applied change detection mode into a code block instead of having them > inline. > Fine by me :) > vzdump.adoc | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/vzdump.adoc b/vzdump.adoc > index 415742e..10dff9e 100644 > --- a/vzdump.adoc > +++ b/vzdump.adoc > @@ -149,11 +149,11 @@ With backup fleecing, such old data is cached in a fleecing image rather than > sent directly to the backup target. This can help guest IO performance and even > prevent hangs in certain scenarios, at the cost of requiring more storage space. > > -Use e.g. `vzdump 123 --fleecing enabled=1,storage=local-lvm` to enable backup > -fleecing, with fleecing images created on the storage `local-lvm`. As always, > -you can set the option for specific backup jobs, or as a node-wide fallback via > -the xref:vzdump_configuration[configuration options]. In the UI, fleecing can be > -configured in the 'Advanced' tab when editing a backup job. > +To manually run a backup of guest `123` with fleecing images created on the Fleecing is only supported for VMs, so I don't like the use of 'guest' here, let's use 'VM' instead. > +storage `local-lvm`, run `vzdump 123 --fleecing enabled=1,storage=local-lvm`. As The duplicate 'run' in the sentence can be fine, but maybe having the first 'run' be 'start' instead reads slightly nicer? > +always, you can set the option for specific backup jobs, or as a node-wide > +fallback via the xref:vzdump_configuration[configuration options]. In the UI, > + fleecing can be configured in the 'Advanced' tab when editing a backup job. > > The fleecing storage should be a fast local storage, with thin provisioning and > discard support. Examples are LVM-thin, RBD, ZFS with `sparse 1` in the storage _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel