From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 2A71D8540 for ; Wed, 21 Jun 2023 15:43:23 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 09AB51E2F3 for ; Wed, 21 Jun 2023 15:43:23 +0200 (CEST) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Wed, 21 Jun 2023 15:43:22 +0200 (CEST) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 55B9342445 for ; Wed, 21 Jun 2023 15:43:22 +0200 (CEST) Date: Wed, 21 Jun 2023 15:43:21 +0200 (CEST) From: Christian Ebner To: pve-devel@lists.proxmox.com Message-ID: <2078053640.624.1687355001676@webmail.proxmox.com> In-Reply-To: <20230621132853.25144-1-c.ebner@proxmox.com> References: <20230621132853.25144-1-c.ebner@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev47 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL -0.004 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - URIBL_BLOCKED 0.001 ADMINISTRATOR NOTICE: The query to URIBL was blocked. See http://wiki.apache.org/spamassassin/DnsBlocklists#dnsbl-block for more information. [plugin.pm] Subject: Re: [pve-devel] [PATCH storage] plugin: handle invalid storage types X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jun 2023 13:43:23 -0000 Oops, I send the wrong patch file here, will send the correct one as v2. Please ignore this one. > On 21.06.2023 15:28 CEST Christian Ebner wrote: > > > Warn and skip if a storage with unknown storage type is encountered. > This might happen by manually editing the storage config. > > Signed-off-by: Christian Ebner > --- > src/PVE/Storage/Plugin.pm | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/src/PVE/Storage/Plugin.pm b/src/PVE/Storage/Plugin.pm > index 9d3b1ae..7e7749d 100644 > --- a/src/PVE/Storage/Plugin.pm > +++ b/src/PVE/Storage/Plugin.pm > @@ -520,6 +520,10 @@ sub parse_config { > my $type = $d->{type}; > > my $def = $defaultData->{plugindata}->{$type}; > + if (!$def) { > + warn "invalid storage type for '$d'\n"; > + next; > + } > > if ($def->{content}) { > $d->{content} = $def->{content}->[1] if !$d->{content}; > -- > 2.39.2