From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 617D56AB2D for ; Mon, 15 Mar 2021 13:57:27 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 581C821386 for ; Mon, 15 Mar 2021 13:57:27 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [212.186.127.180]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS id AB53321379 for ; Mon, 15 Mar 2021 13:57:26 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id 721B6441EB for ; Mon, 15 Mar 2021 13:57:26 +0100 (CET) Message-ID: <2068feb4-9612-7e35-3ad4-28012a48be64@proxmox.com> Date: Mon, 15 Mar 2021 13:57:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:87.0) Gecko/20100101 Thunderbird/87.0 Content-Language: en-US To: Proxmox VE development discussion , Fabian Ebner References: <20210312095027.19451-1-f.ebner@proxmox.com> From: Thomas Lamprecht In-Reply-To: <20210312095027.19451-1-f.ebner@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL -0.048 Adjusted score from AWL reputation of From: address KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: [pve-devel] applied: [PATCH storage 1/2] vdisk list: only collect images from storages with an appropriate content type X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Mar 2021 12:57:27 -0000 On 12.03.21 10:50, Fabian Ebner wrote: > Only these storages are activated in the first place, and it's bad behavior to > list images when no appropriate content type is not set. > > For example, on VM destruction, this avoids unreferenced images to be deleted > from a storage with only 'backup' content type set, which is supposedly what > happened in this[0] forum thread. > > (Some) callers expect all keys to be present and valid array references in the > result, so initialization is needed. > > Now, the enabled check is already done by the preceding code for every element > that is iterated over, and thus isn't needed in the main loop anymore. > > [0]: https://forum.proxmox.com/threads/erasing-all-vm-disks-after-a-failed-vm-migration-task.85068 > > Signed-off-by: Fabian Ebner > --- > > Why isn't 'iterand' a word? > Seems like it has at least some use in the wild, and may be clear enough to no cause confusion when used. https://softwareengineering.stackexchange.com/a/310191 > PVE/Storage.pm | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > applied, thanks!