From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.proxmox.com (Postfix) with ESMTPS id 8D9BE991F3 for ; Thu, 16 Nov 2023 10:40:32 +0100 (CET) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 699FE10D50 for ; Thu, 16 Nov 2023 10:40:32 +0100 (CET) Received: from proxmox-new.maurer-it.com (proxmox-new.maurer-it.com [94.136.29.106]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by firstgate.proxmox.com (Proxmox) with ESMTPS for ; Thu, 16 Nov 2023 10:40:30 +0100 (CET) Received: from proxmox-new.maurer-it.com (localhost.localdomain [127.0.0.1]) by proxmox-new.maurer-it.com (Proxmox) with ESMTP id A7865436A1 for ; Thu, 16 Nov 2023 10:40:30 +0100 (CET) Date: Thu, 16 Nov 2023 10:40:29 +0100 (CET) From: Christian Ebner To: Proxmox VE development discussion , Philipp Hufnagl Message-ID: <203276037.3875.1700127629707@webmail.proxmox.com> In-Reply-To: <20231115160042.177037-3-p.hufnagl@proxmox.com> References: <20231115160042.177037-1-p.hufnagl@proxmox.com> <20231115160042.177037-3-p.hufnagl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev54 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.055 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record T_SCC_BODY_TEXT_LINE -0.01 - Subject: Re: [pve-devel] [PATCH storage v2 2/4] pbs: Make it possible to reuse PBS connection for datastore API call X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 16 Nov 2023 09:40:32 -0000 > On 15.11.2023 17:00 CET Philipp Hufnagl wrote: > > > It would be nice to reuse an existing PBS connection for scan_datastore. > Because scan_datastore is used multiple in the code, it can not be > canged without breaking existing code. Typo s/canged/changed. > > This change add an optional connection parameter to scan_datastore. If > it is passed it will use this connection. If not, it will create a new > one. > > Signed-off-by: Philipp Hufnagl > --- > src/PVE/Storage/PBSPlugin.pm | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/PVE/Storage/PBSPlugin.pm b/src/PVE/Storage/PBSPlugin.pm > index 96373a4..81df21e 100644 > --- a/src/PVE/Storage/PBSPlugin.pm > +++ b/src/PVE/Storage/PBSPlugin.pm > @@ -808,9 +808,11 @@ sub status { > # fingerprint (optional for trusted certs) > # } > sub scan_datastores { > - my ($scfg, $password) = @_; > + my ($scfg, $password, $conn) = @_; > > - my $conn = pbs_api_connect($scfg, $password); > + if (!defined($conn)){ > + $conn = pbs_api_connect($scfg, $password); > + } This can be written more compactly as: $conn = pbs_api_connect($scfg, $password) if !defined($conn); > > my $response = eval { $conn->get('/api2/json/admin/datastore', {}) }; > die "error fetching datastores - $@" if $@; > -- > 2.39.2 > > > > _______________________________________________ > pve-devel mailing list > pve-devel@lists.proxmox.com > https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel