From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from firstgate.proxmox.com (firstgate.proxmox.com [212.224.123.68]) by lore.proxmox.com (Postfix) with ESMTPS id C02881FF187 for ; Mon, 14 Jul 2025 13:04:02 +0200 (CEST) Received: from firstgate.proxmox.com (localhost [127.0.0.1]) by firstgate.proxmox.com (Proxmox) with ESMTP id 164DD146F1; Mon, 14 Jul 2025 13:05:00 +0200 (CEST) Date: Mon, 14 Jul 2025 13:04:26 +0200 (CEST) From: =?UTF-8?Q?Fabian_Gr=C3=BCnbichler?= To: "DERUMIER, Alexandre" , "pve-devel@lists.proxmox.com" Message-ID: <2031346726.5791.1752491066605@192.168.2.153> In-Reply-To: <719c71b1148846e0cdd7e5c149d8b20146b4d043.camel@groupe-cyllene.com> References: <573493064.5243.1752160423097@webmail.proxmox.com> <719c71b1148846e0cdd7e5c149d8b20146b4d043.camel@groupe-cyllene.com> MIME-Version: 1.0 X-Priority: 3 Importance: Normal X-Mailer: Open-Xchange Mailer v7.10.6-Rev79 X-Originating-Client: open-xchange-appsuite X-SPAM-LEVEL: Spam detection results: 0 AWL 0.047 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Subject: Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support X-BeenThere: pve-devel@lists.proxmox.com X-Mailman-Version: 2.1.29 Precedence: list List-Id: Proxmox VE development discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Proxmox VE development discussion Cc: "w.bumiller@proxmox.com" , "t.lamprecht@proxmox.com" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: pve-devel-bounces@lists.proxmox.com Sender: "pve-devel" > DERUMIER, Alexandre hat am 14.07.2025 10:42 CEST geschrieben: > > > >>6. it's fairly easy to accidentally create qcow2-formatted LVM > >>volumes, as opposed to the requirement to enable a non-UI storage > >>option at storage creation time for dir storages, we might want to > >>add some warning to the UI at least? or we could also guard usage of > >>the format with a config option.. > > Personnaly, this don't shock that's much > > the external-snapshot option is to distinguished between > internal|external snapshot. > > you can also "accidentally" create a qcow2 file instead a raw file on > dir storage. yes, but that one has been tested for a while, the LVM one is new and still experimental, but that is not obvious from the UI. > so I think that a warning in the UI is fine enough if qcow2 format is > selected. would probably need to go into a few places then (allocating a disk, moving it, restore of backup - at least?) _______________________________________________ pve-devel mailing list pve-devel@lists.proxmox.com https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel