From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 00ABF1FF0AB for ; Wed, 23 Sep 2026 12:00:43 +0200 (CEST) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 580F221594; Wed, 23 Sep 2026 12:00:30 +0200 (CEST) Message-ID: <202da899-a865-4630-bf12-42a52d4ec9d2@proxmox.com> Date: Wed, 23 Sep 2026 12:00:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH proxmox-firewall] nftables: build without the config extension To: pve-devel@lists.proxmox.com References: <20260827115803.1331245-1-h.laimer@proxmox.com> Content-Language: en-US From: Stefan Hanreich In-Reply-To: <20260827115803.1331245-1-h.laimer@proxmox.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.704 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record URIBL_CSS_A 0.1 Contains URL's A record listed in the Spamhaus CSS blocklist [23.95.107.30] Message-ID-Hash: CUZQLYAQVA23BL62KLGZDUYQF7KQN23K X-Message-ID-Hash: CUZQLYAQVA23BL62KLGZDUYQF7KQN23K X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: lgtm Reviewed-by: Stefan Hanreich Tested-by: Stefan Hanreich On 8/27/26 1:58 PM, Hannes Laimer wrote: > The bridge-name import and the anyhow imports were unconditional > although only the config extension uses them, so without that feature > the crate failed to build and warned about unused imports. > > Signed-off-by: Hannes Laimer > --- > proxmox-nftables/src/expression.rs | 3 ++- > proxmox-nftables/src/statement.rs | 1 + > 2 files changed, 3 insertions(+), 1 deletion(-) > > diff --git a/proxmox-nftables/src/expression.rs b/proxmox-nftables/src/expression.rs > index 0b46cc5..ca7a4e7 100644 > --- a/proxmox-nftables/src/expression.rs > +++ b/proxmox-nftables/src/expression.rs > @@ -1,5 +1,4 @@ > use crate::types::{ElemConfig, Verdict}; > -use proxmox_ve_config::host::types::BridgeName; > use serde::{Deserialize, Serialize}; > use std::net::{IpAddr, Ipv4Addr, Ipv6Addr}; > > @@ -13,6 +12,8 @@ use proxmox_ve_config::firewall::types::port::{PortEntry, PortList}; > use proxmox_ve_config::firewall::types::rule_match::{IcmpCode, IcmpType, Icmpv6Code, Icmpv6Type}; > #[cfg(feature = "config-ext")] > use proxmox_ve_config::guest::types::Vmid; > +#[cfg(feature = "config-ext")] > +use proxmox_ve_config::host::types::BridgeName; > > #[derive(Clone, Debug, Deserialize, Serialize)] > #[serde(rename_all = "lowercase")] > diff --git a/proxmox-nftables/src/statement.rs b/proxmox-nftables/src/statement.rs > index d8899a8..44a4c48 100644 > --- a/proxmox-nftables/src/statement.rs > +++ b/proxmox-nftables/src/statement.rs > @@ -1,3 +1,4 @@ > +#[cfg(feature = "config-ext")] > use anyhow::{Error, bail}; > use serde::{Deserialize, Serialize}; >