From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id D361C1FF0B2 for ; Sun, 22 Nov 2026 02:27:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D4BDF216EB; Sun, 22 Nov 2026 02:26:41 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v3 manager 13/18] ui: lvm: offer NVMe over Fabrics storages as base storage Date: Sun, 22 Nov 2026 02:25:50 +0100 Message-ID: <20261122012605.1848824-14-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261122012605.1848824-1-t.lamprecht@proxmox.com> References: <20261122012605.1848824-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795310772223 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.146 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 6POTQWKR7FSRKF5CJ37KF6EHE2XU6NKP X-Message-ID-Hash: 6POTQWKR7FSRKF5CJ37KF6EHE2XU6NKP X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A namespace of an NVMe over Fabrics storage can hold the volume group of an LVM storage like an iSCSI LUN, so list such storages in the base storage selector as well and name the type of each. Signed-off-by: Thomas Lamprecht --- www/manager6/dc/StorageView.js | 4 ++-- www/manager6/storage/LVMEdit.js | 12 ++++++++---- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/www/manager6/dc/StorageView.js b/www/manager6/dc/StorageView.js index 6afea33ce..5f4f519be 100644 --- a/www/manager6/dc/StorageView.js +++ b/www/manager6/dc/StorageView.js @@ -250,9 +250,9 @@ Ext.define( lvm: [ 'local', gettext( - 'Use an existing volume group, or create one on a LUN of an iSCSI storage.', + 'Use an existing volume group, or create one on an iSCSI LUN or NVMe/TCP namespace.', ), - 'san lun shared', + 'san lun shared nvme namespace', ], lvmthin: ['local', gettext('Use an existing LVM thin pool.'), ''], zfspool: ['local', gettext('Use an existing ZFS pool or dataset.'), 'zpool'], diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js index 688130b19..146dac12c 100644 --- a/www/manager6/storage/LVMEdit.js +++ b/www/manager6/storage/LVMEdit.js @@ -70,10 +70,13 @@ Ext.define('PVE.storage.BaseStorageSelector', { let store = Ext.create('Ext.data.Store', { autoLoad: { addRecords: true, - params: { - type: 'iscsi', - }, }, + filters: [ + { + filterFn: (rec) => + !rec.get('storage') || ['iscsi', 'nvmeof'].includes(rec.get('type')), + }, + ], fields: [ 'storage', 'type', @@ -82,7 +85,8 @@ Ext.define('PVE.storage.BaseStorageSelector', { name: 'text', convert: function (value, record) { if (record.data.storage) { - return record.data.storage + ' (iSCSI)'; + let type = PVE.Utils.format_storage_type(record.data.type); + return `${record.data.storage} (${type})`; } else { return me.existingGroupsText; }