From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id AA14F1FF0AF for ; Fri, 20 Nov 2026 17:06:21 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 8D7BC2170C; Fri, 20 Nov 2026 17:06:20 +0100 (CET) From: Jakob Klocker To: pve-devel@lists.proxmox.com Subject: [PATCH pve-storage-plugin-examples v4 2/7] backup provider example: reset per-guest state in backup_init Date: Fri, 20 Nov 2026 17:05:05 +0100 Message-ID: <20261120160510.311796-3-j.klocker@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120160510.311796-1-j.klocker@proxmox.com> References: <20261120160510.311796-1-j.klocker@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795190776462 X-SPAM-LEVEL: Spam detection results: 0 AWL 1.158 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: UJB6PGRUGIQ7OVBDYQQHCDX7IRHHLOSH X-Message-ID-Hash: UJB6PGRUGIQ7OVBDYQQHCDX7IRHHLOSH X-MailFrom: j.klocker@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: With backup retries, backup_init() can be called again for the same guest within one job. Reset the per-guest state, so a retry does not inherit the 'failed' flag or the removed backing image of the failed attempt. Signed-off-by: Jakob Klocker --- .../src/PVE/BackupProvider/Plugin/DirectoryExample.pm | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/backup-provider-directory/src/PVE/BackupProvider/Plugin/DirectoryExample.pm b/backup-provider-directory/src/PVE/BackupProvider/Plugin/DirectoryExample.pm index f61198b..2a53956 100644 --- a/backup-provider-directory/src/PVE/BackupProvider/Plugin/DirectoryExample.pm +++ b/backup-provider-directory/src/PVE/BackupProvider/Plugin/DirectoryExample.pm @@ -174,6 +174,10 @@ sub job_cleanup { sub backup_init { my ($self, $vmid, $vmtype, $backup_time) = @_; + # Start with fresh per-guest state. A failed attempt of the same job may have left + # state behind, like the 'failed' flag or 'previous' pointing to its removed directory. + $self->{$vmid} = {}; + my $archive_subdir = "${vmtype}-${backup_time}"; my $archive = "${vmid}/${archive_subdir}"; -- 2.47.3