From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 381321FF0AF for ; Fri, 20 Nov 2026 17:01:55 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id DB6E2218AF; Fri, 20 Nov 2026 17:00:41 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 09/10] ui: sdn: fabrics: wireguard: support resetting the interfaces Date: Fri, 20 Nov 2026 17:00:24 +0100 Message-ID: <20261120160026.512565-10-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120160026.512565-1-s.hanreich@proxmox.com> References: <20261120160026.512565-1-s.hanreich@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795190433485 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.200 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ILGRTFK6Z4TCEZIJ2YQIXEVE6MLBXMPF X-Message-ID-Hash: ILGRTFK6Z4TCEZIJ2YQIXEVE6MLBXMPF X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Resetting the form data of the node edit window had no effect on the interfaces of a WireGuard node, since the interface panel only used the default reset of the field mixin, which does not touch the interface store. Reload the interfaces of the node, or remove all interfaces when creating a node, and update the dirty and validity state afterwards, so that the window updates its buttons. Peers that reference missing interfaces are only reported when loading the node, not again on every reset. Signed-off-by: Stefan Hanreich --- .../sdn/fabrics/wireguard/InterfacePanel.js | 89 ++++++++++++------- 1 file changed, 59 insertions(+), 30 deletions(-) diff --git a/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js b/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js index 8c5def67..7ba53efd 100644 --- a/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js +++ b/www/manager6/sdn/fabrics/wireguard/InterfacePanel.js @@ -458,7 +458,8 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', { me.getViewModel().set('availablePeers', availablePeers); }, - setNode: async function (node) { + // returns the peers that were dropped, since their interface does not exist on the node + loadInterfaces: function (node) { let me = this; let ifaces = {}; @@ -485,6 +486,27 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', { Ext.create('Pve.sdn.Fabric.WireGuard.InterfacePeer', peer), ); } + + me.getViewModel().set('currentNode', node); + + me.isLoading = true; + try { + me.getViewModel().getStore('interfaces').setData(Object.values(ifaces)); + } finally { + me.isLoading = false; + } + + me.selectFirstInterface(); + + return droppedPeers; + }, + + setNode: async function (node) { + let me = this; + + me.loadedNode = node; + + let droppedPeers = me.loadInterfaces(node); if (droppedPeers.length > 0) { console.warn( `WireGuard: dropping ${droppedPeers.length} peer(s) referencing missing interfaces:`, @@ -501,17 +523,20 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', { ); } - me.getViewModel().set('currentNode', node); + me.previousDirty = false; + }, - me.isLoading = true; - try { - me.getViewModel().getStore('interfaces').setData(Object.values(ifaces)); - } finally { - me.isLoading = false; + reset: function () { + let me = this; + + if (me.loadedNode) { + // the dropped peers were already reported when loading the node + me.loadInterfaces(me.loadedNode); + } else { + me.getViewModel().getStore('interfaces').removeAll(); } - me.previousDirty = false; - me.selectFirstInterface(); + me.refreshState(); }, isDirty: function () { @@ -562,6 +587,25 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', { .items.every((iface) => me.isInterfaceValid(iface)); }, + refreshState: function () { + let me = this; + + if (me.isLoading) { + return; + } + let dirtyStatus = me.isDirty(); + if (dirtyStatus !== me.previousDirty) { + me.previousDirty = dirtyStatus; + me.fireEvent('dirtychange'); + } + + let validStatus = me.isValid(); + if (validStatus !== me.previousValid) { + me.previousValid = validStatus; + me.fireEvent('validitychange', me, validStatus); + } + }, + initComponent: function () { let me = this; @@ -569,31 +613,16 @@ Ext.define('PVE.sdn.Fabric.WireGuard.InterfacePanel', { let store = me.getViewModel().getStore('interfaces'); - let refreshDirty = () => { - if (me.isLoading) { - return; - } - let dirtyStatus = me.isDirty(); - if (dirtyStatus !== me.previousDirty) { - me.previousDirty = dirtyStatus; - me.fireEvent('dirtychange'); - } - - let validStatus = me.isValid(); - if (validStatus !== me.previousValid) { - me.previousValid = validStatus; - me.fireEvent('validitychange', me, validStatus); - } - }; + let refreshState = () => me.refreshState(); me.lookupReference('peerSelector').on({ - datachanged: refreshDirty, - update: refreshDirty, + datachanged: refreshState, + update: refreshState, }); store.on({ - add: refreshDirty, - remove: refreshDirty, - update: refreshDirty, + add: refreshState, + remove: refreshState, + update: refreshState, }); }, -- 2.47.3