From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0ED171FF0AF for ; Fri, 20 Nov 2026 14:33:22 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id BCBEF217D8; Fri, 20 Nov 2026 14:32:57 +0100 (CET) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH manager 3/4] ui: lvm: keep other on-volume-remove options when editing Date: Fri, 20 Nov 2026 14:32:42 +0100 Message-ID: <20261120133245.51042-4-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120133245.51042-1-l.sichert@proxmox.com> References: <20261120133245.51042-1-l.sichert@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795181573269 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.445 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HIATOKLRIN3YKBHUVE42EEGJNGS2U3QX X-Message-ID-Hash: HIATOKLRIN3YKBHUVE42EEGJNGS2U3QX X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The edit dialog rebuilt the on-volume-remove property string from the discard checkbox alone, so saving the dialog dropped every other option in it. This would silently remove options that can only be set through the API or CLI, such as discard_throughput. Remember the options without a field of their own when loading the storage and submit them again with the checkbox state. Signed-off-by: Lukas Sichert --- www/manager6/storage/LVMEdit.js | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/www/manager6/storage/LVMEdit.js b/www/manager6/storage/LVMEdit.js index 9308ef4e..75861214 100644 --- a/www/manager6/storage/LVMEdit.js +++ b/www/manager6/storage/LVMEdit.js @@ -151,7 +151,8 @@ Ext.define('PVE.storage.LVMInputPanel', { onGetValues: function (values) { let me = this; - let onRemove = {}; + // options without a field of their own, like discard_throughput, must survive an edit + let onRemove = { ...me.otherOnRemoveOptions }; if (values['on-remove-discard']) { onRemove.discard = 1; } @@ -178,6 +179,8 @@ Ext.define('PVE.storage.LVMInputPanel', { if (values['on-volume-remove']) { let onRemove = PVE.Parser.parsePropertyString(values['on-volume-remove']); values['on-remove-discard'] = onRemove.discard; + delete onRemove.discard; + this.otherOnRemoveOptions = onRemove; } delete values['on-volume-remove']; -- 2.47.3