From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id EC2961FF0AF for ; Fri, 20 Nov 2026 13:52:42 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id D879A216FF; Fri, 20 Nov 2026 13:52:39 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager 3/3] ui: dc: san: show missing open-iscsi in the node grid Date: Fri, 20 Nov 2026 13:51:55 +0100 Message-ID: <20261120125236.2393788-4-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261120125236.2393788-1-d.csapak@proxmox.com> References: <20261120125236.2393788-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.269 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XRJ5ZEVP6OH4THM2P5QEZSFVGCRHFNBQ X-Message-ID-Hash: XRJ5ZEVP6OH4THM2P5QEZSFVGCRHFNBQ X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: show 'open-iscsi not installed' instead of the initiator name for nodes that don't report one. Don't show it as state, since a node does not need open-iscsi if it only uses e.g. Fibre Channel, so it's not an error there. Signed-off-by: Dominik Csapak --- www/manager6/SANUtils.js | 8 ++++++++ www/manager6/dc/SAN.js | 7 ++++++- 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/www/manager6/SANUtils.js b/www/manager6/SANUtils.js index 90ddd1eb..ed76ce40 100644 --- a/www/manager6/SANUtils.js +++ b/www/manager6/SANUtils.js @@ -129,6 +129,14 @@ Ext.define('PVE.SANUtils', { return report.state !== 'no-report' && !report['iscsi-initiator-name']; }, + renderInitiatorName: function (value, metaData, rec) { + if (rec.get('iscsi-missing')) { + let text = Ext.htmlEncode(gettext('open-iscsi not installed')); + return ` ${text}`; + } + return Ext.htmlEncode(value); + }, + renderState: function (value) { if (!value) { return ''; diff --git a/www/manager6/dc/SAN.js b/www/manager6/dc/SAN.js index 530d96a1..d55a2339 100644 --- a/www/manager6/dc/SAN.js +++ b/www/manager6/dc/SAN.js @@ -9,6 +9,11 @@ Ext.define('pve-san-status', { 'apply-error', 'time', 'iscsi-initiator-name', + { + name: 'iscsi-missing', + depends: ['kind', 'state', 'iscsi-initiator-name'], + calculate: (data) => data.kind === 'node' && PVE.SANUtils.iscsiMissing(data), + }, 'other-maps', 'wwid', 'name', @@ -175,7 +180,7 @@ Ext.define('PVE.dc.SANView', { text: gettext('iSCSI Initiator Name'), dataIndex: 'iscsi-initiator-name', flex: 2, - renderer: Ext.htmlEncode, + renderer: PVE.SANUtils.renderInitiatorName, }, { text: gettext('Other Maps'), -- 2.47.3