From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E98271FF0DA for ; Thu, 19 Nov 2026 20:23:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C591321A37; Thu, 19 Nov 2026 20:20:18 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH manager v5 33/41] ui: guest summary: show the guest identity Date: Thu, 19 Nov 2026 20:19:05 +0100 Message-ID: <20261119191914.2336934-34-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261119191914.2336934-1-t.lamprecht@proxmox.com> References: <20261119191914.2336934-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795115961156 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.157 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZNZXHA4YYMVW6K5UTQALYIRHFRUDCIBF X-Message-ID-Hash: ZNZXHA4YYMVW6K5UTQALYIRHFRUDCIBF X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The 'meta' property of a guest holds its identity: a unique ID and the time the guest was registered in this cluster. It also holds the creation time and, for VMs, the QEMU version the VM was created with. The web UI showed none of it, so comparing a guest with what a backup or monitoring tool reports for it required reading the config or the API. Show the unique ID in its own row of the status panel of the guest summary, also for templates, as it is the value such tools report. A button next to it opens a window with all these values. The unique ID is in a read-only text field, so it can be selected and copied. The row uses the uid that the guest status already returns, so the summary makes no extra periodic request, and the window loads the guest config once when opened. Guests without a uid, for example on nodes that do not handle the identity yet, get no row. Signed-off-by: Thomas Lamprecht Reviewed-by: Dominik Csapak Tested-by: Dominik Csapak --- no changes since v4 changes v3 -> v4: * the window no longer shows the cluster ID, which the datacenter summary has now, and so no longer requests the cluster status * request the config without 'current', as the config view never applies a pending 'meta' www/manager6/Makefile | 1 + www/manager6/panel/GuestIdentity.js | 120 +++++++++++++++++++++++ www/manager6/panel/GuestStatusView.js | 3 + www/manager6/panel/TemplateStatusView.js | 3 + 4 files changed, 127 insertions(+) create mode 100644 www/manager6/panel/GuestIdentity.js diff --git a/www/manager6/Makefile b/www/manager6/Makefile index e8e2bd0b..24ad74cb 100644 --- a/www/manager6/Makefile +++ b/www/manager6/Makefile @@ -113,6 +113,7 @@ JSSRC= \ panel/IPView.js \ panel/RunningChart.js \ panel/StatusPanel.js \ + panel/GuestIdentity.js \ panel/GuestStatusView.js \ panel/GuestSummary.js \ panel/TemplateStatusView.js \ diff --git a/www/manager6/panel/GuestIdentity.js b/www/manager6/panel/GuestIdentity.js new file mode 100644 index 00000000..beba495b --- /dev/null +++ b/www/manager6/panel/GuestIdentity.js @@ -0,0 +1,120 @@ +Ext.define('PVE.window.GuestIdentity', { + extend: 'Ext.window.Window', + alias: 'widget.pveGuestIdentityWindow', + + title: gettext('Guest Identity'), + width: 450, + modal: true, + resizable: false, + bodyPadding: 10, + + layout: 'anchor', + defaults: { + anchor: '100%', + labelWidth: 130, + }, + + // the parsed 'meta' property of the guest config + meta: {}, + + initComponent: function () { + let me = this; + + let meta = me.meta; + let renderTime = (seconds) => + Ext.isNumeric(seconds) ? PVE.Utils.render_timestamp_human_readable(seconds) : ''; + + let fields = [ + { + xtype: 'textfield', + itemId: 'uid', + fieldLabel: gettext('Unique ID'), + value: meta.uid, + editable: false, + }, + { + xtype: 'displayfield', + itemId: 'rtime', + fieldLabel: gettext('Registered'), + value: renderTime(meta.rtime / 1000), + }, + { + xtype: 'displayfield', + itemId: 'ctime', + fieldLabel: gettext('Created'), + value: renderTime(meta.ctime), + }, + { + xtype: 'displayfield', + itemId: 'creation-qemu', + fieldLabel: gettext('Created with QEMU'), + value: meta['creation-qemu'], + }, + ]; + me.items = fields.filter((field) => (field.value ?? '') !== ''); + + me.callParent(); + }, +}); + +Ext.define('PVE.panel.GuestIdentityInfo', { + extend: 'Ext.container.Container', + alias: 'widget.pveGuestIdentityInfo', + + hidden: true, + layout: { + type: 'hbox', + align: 'middle', + }, + + items: [ + { + xtype: 'pmxInfoWidget', + flex: 1, + iconCls: 'fa fa-id-card-o fa-fw', + title: gettext('Unique ID'), + printBar: false, + textField: 'uid', + // the status view only updates info widgets, so this one shows or hides the whole row + renderer: function (uid) { + this.up('pveGuestIdentityInfo').setHidden(!uid); + return Ext.htmlEncode(uid); + }, + }, + { + xtype: 'button', + iconCls: 'fa fa-info-circle', + tooltip: gettext('Details'), + ariaLabel: gettext('Details'), + ui: 'default-toolbar', + margin: '0 0 0 5', + handler: function () { + this.up('pveGuestIdentityInfo').showDetails(); + }, + }, + ], + + showDetails: async function () { + let me = this; + + let view = me.up('pmxStatusView'); + let { node, vmid, type } = view.pveSelNode.data; + + let response; + try { + response = await Proxmox.Async.api2({ + url: `/nodes/${node}/${type}/${vmid}/config`, + method: 'GET', + waitMsgTarget: view, + }); + } catch (error) { + Ext.Msg.alert(gettext('Error'), error.htmlStatus); + return; + } + + Ext.create('PVE.window.GuestIdentity', { + autoShow: true, + meta: PVE.Parser.parsePropertyString(response.result.data.meta) ?? {}, + }); + }, +}); diff --git a/www/manager6/panel/GuestStatusView.js b/www/manager6/panel/GuestStatusView.js index 315d3420..00851b07 100644 --- a/www/manager6/panel/GuestStatusView.js +++ b/www/manager6/panel/GuestStatusView.js @@ -92,6 +92,9 @@ Ext.define('PVE.panel.GuestStatusView', { hidden: '{isQemu}', }, }, + { + xtype: 'pveGuestIdentityInfo', + }, { xtype: 'box', height: 10, diff --git a/www/manager6/panel/TemplateStatusView.js b/www/manager6/panel/TemplateStatusView.js index 8742cfc2..26732386 100644 --- a/www/manager6/panel/TemplateStatusView.js +++ b/www/manager6/panel/TemplateStatusView.js @@ -30,6 +30,9 @@ Ext.define('PVE.panel.TemplateStatusView', { iconCls: 'fa fa-fw fa-building', title: gettext('Node'), }, + { + xtype: 'pveGuestIdentityInfo', + }, { xtype: 'box', height: 20, -- 2.47.3