From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 240D01FF0DA for ; Thu, 19 Nov 2026 19:45:28 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id E231D216A4; Thu, 19 Nov 2026 19:45:25 +0100 (CET) From: Jordyn Hamilton To: pve-devel@lists.proxmox.com Subject: [PATCH common v2] Added D state checking to `run` subroutine Date: Thu, 19 Nov 2026 13:45:01 -0500 Message-ID: <20261119184502.22359-1-j.hamilton@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795113920512 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.082 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: E6CLNDC4T4BEOP27MZJMCI4MVPDBFWC3 X-Message-ID-Hash: E6CLNDC4T4BEOP27MZJMCI4MVPDBFWC3 X-MailFrom: j.hamilton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: j.hamilton@proxmox.com, c.hughes@proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Added a subroutine to check if a process is in a D state. It does so by reading the processes `stat` file from `/proc/$pid/stat`, then using regex to grab a group containing the status character. It then returns true or false if the status is 'D'. Not checking for any other status types as D state is the only one that needs special logic. Added flow to check for a D state and customize the error message to reflect that state within the timeout logic tree. The timeout branch was chosen since the d state check would only be required if the process takes long enough to time out. Logic tree queues a `SIGKILL` prior to any D state checking, as the system would queue the signal if the process is in a D state, meaning it would auto terminate once the state resolves. This also means the standard timeout error checking remains untouched, it still sends the signal, waits for the process to terminate then dies. Since there is no way to terminate D state processes programatically, the program only overwrites the error message then dies, orphaning the D state process while allowing future processes relying on the completion of this one to run. It directs the user in the right direction for debugging and provides all the information necessary for beginning that process including the `$pid` and `$cmd_str`. from v2: - Pulled master from remote and rebased branch off master to resolve merge conflicts. - Modified function calls to use parentheses in accordance with the perl style guide - Modified error message string to be fomatted by perl style guides - Squashed commits into one Signed-off-by: Jordyn Hamilton --- src/PVE/Cmd.pm | 24 ++++++++++++++++++++++++ 1 file changed, 24 insertions(+) diff --git a/src/PVE/Cmd.pm b/src/PVE/Cmd.pm index 7dee654..9715a06 100644 --- a/src/PVE/Cmd.pm +++ b/src/PVE/Cmd.pm @@ -44,6 +44,18 @@ sub split_args($str) { return $str ? [Text::ParseWords::shellwords($str)] : []; } +# check a subprocesses `/proc//stat` file for a D state +sub in_d_state($pid) { + open(my $pstat_h, '<', "/proc/$pid/stat") or die $!; + my $stat_in = <$pstat_h>; + close($pstat_h); + + # extracting the stat character from the input + my $status = $1 if ($stat_in =~ /^\d+\s+\(.*\)\s+([A-Z])/); + + return ($status eq 'D'); +} + # The $cmd parameter can be: # -) a string # This is generally executed by passing it to the shell with the -c option. @@ -321,6 +333,18 @@ sub run($cmd, %param) { if ($err) { if ($pid && ($err eq "got timeout\n")) { + kill(9, $pid); + if (in_d_state($pid)) { + $err = "process '$pid' is in an uninterruptible sleep" + . " and cannot resolve or be terminated by this program.\n" + . "This process can only be terminated by" + . " resolving the errors or performing a system reboot.\n" + . "This is due to underlying kernel or hardware errors," + . " check dmesg for errors or" + . " kernel messages.\n"; + }else { + waitpid($pid, 0); + } die "command '$cmdstr' failed: $err"; } -- 2.47.3