From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id DCECE1FF0E3 for ; Wed, 18 Nov 2026 21:43:27 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 05E0921805; Wed, 18 Nov 2026 21:43:13 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v2 storage 05/17] pvesm: add a scan command for NVMe over Fabrics Date: Wed, 18 Nov 2026 21:42:24 +0100 Message-ID: <20261118204302.3100813-6-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118204302.3100813-1-t.lamprecht@proxmox.com> References: <20261118204302.3100813-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795034587384 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.162 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: MHSBODH3QZLC7XIYJIFDDCV43NLIERMJ X-Message-ID-Hash: MHSBODH3QZLC7XIYJIFDDCV43NLIERMJ X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Add 'pvesm scan nvmeof ', which prints the subsystems a portal offers to the node with their portals, like the iSCSI scan prints targets. That gives the values for a new storage on the command line, with the usual output formats for scripts. Signed-off-by: Thomas Lamprecht --- src/PVE/CLI/pvesm.pm | 13 +++++++++++++ src/test/run_nvmeof_tests.pl | 12 ++++++++++++ 2 files changed, 25 insertions(+) diff --git a/src/PVE/CLI/pvesm.pm b/src/PVE/CLI/pvesm.pm index 8c3a2eda..b60b733b 100755 --- a/src/PVE/CLI/pvesm.pm +++ b/src/PVE/CLI/pvesm.pm @@ -736,6 +736,19 @@ our $cmddef = { $print_api_result, $PVE::RESTHandler::standard_output_options, ], + nvmeof => [ + "PVE::API2::Storage::Scan", + 'nvmeofscan', + ['portal'], + { node => $nodename }, + sub { + my ($data, $schema, $options) = @_; + PVE::CLIFormatter::print_api_result( + $data, $schema, [qw(subsysnqn portals)], $options, + ); + }, + $PVE::RESTHandler::standard_output_options, + ], 'san-luns' => [ "PVE::API2::Storage::Scan", 'sanlunscan', diff --git a/src/test/run_nvmeof_tests.pl b/src/test/run_nvmeof_tests.pl index ffbaa45f..90b34857 100755 --- a/src/test/run_nvmeof_tests.pl +++ b/src/test/run_nvmeof_tests.pl @@ -14,6 +14,7 @@ use PVE::Tools qw(file_set_contents); use PVE::NVMeOF; use PVE::Storage; use PVE::API2::Storage::Scan; +use PVE::CLI::pvesm; my $dir = tempdir('nvmeof-test-XXXX', DIR => '.', CLEANUP => 1); local $PVE::NVMeOF::RUN_DIR = "$dir/run"; @@ -351,6 +352,17 @@ subtest 'TCP discovery, fallback and API result' => sub { @ports = (); PVE::NVMeOF::discover('[2001:db8::1]:4421'); is_deeply(\@ports, [4421], 'explicit port does not fall back'); + my $formatter = Test::MockModule->new('PVE::CLIFormatter'); + my $schema = PVE::API2::Storage::Scan->map_method_by_name('nvmeofscan')->{returns}; + $formatter->mock( + print_api_result => sub { + is($_[0], $rows, 'CLI forwards complete discovery rows'); + is($_[1], $schema, 'CLI forwards discovery schema'); + is($_[3]->{'output-format'}, 'json', 'CLI supports structured output'); + }, + ); + $PVE::CLI::pvesm::cmddef->{scan}->{nvmeof}->[4] + ->($rows, $schema, { 'output-format' => 'json' }); }; done_testing();