From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 7C4711FF0C0 for ; Wed, 18 Nov 2026 15:36:29 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9EC84217A9; Wed, 18 Nov 2026 15:36:00 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v3 8/9] migrate: log messages from remote nbdstop command Date: Wed, 18 Nov 2026 15:27:52 +0100 Message-ID: <20261118143549.199143-9-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118143549.199143-1-f.ebner@proxmox.com> References: <20261118143549.199143-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795012553547 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.248 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2WNQWLYCMWIW45HPUS7E4A7MEGN275IP X-Message-ID-Hash: 2WNQWLYCMWIW45HPUS7E4A7MEGN275IP X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The output was always ignored since the introduction of the command in 2016 with commit b74cad8a ("add live storage migration with vm migration"). But it's nicer to show messages from the remote side to detect failures and for debugging purposes. Signed-off-by: Fiona Ebner --- No changes in v3. src/PVE/QemuMigrate.pm | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/PVE/QemuMigrate.pm b/src/PVE/QemuMigrate.pm index eb8b54b6..bca92ef3 100644 --- a/src/PVE/QemuMigrate.pm +++ b/src/PVE/QemuMigrate.pm @@ -1745,7 +1745,12 @@ sub phase3_cleanup { my $cmd = build_ssh_command($self->{rem_ssh}, ['qm', 'nbdstop', $vmid]); eval { - PVE::Tools::run_command($cmd, outfunc => sub { }, errfunc => sub { }); + PVE::Tools::run_command( + $cmd, + logfunc => sub { + $self->log('info', "[$self->{node}] $_[0]"); + }, + ); }; if (my $err = $@) { $self->log('err', $err); -- 2.47.3