From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 207781FF0C0 for ; Wed, 18 Nov 2026 15:28:58 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 0B21821713; Wed, 18 Nov 2026 15:28:50 +0100 (CET) From: Shannon Sterz To: pve-devel@lists.proxmox.com Subject: [PATCH cluster 1/2] cluster: setup: keep file permissions for sshd config Date: Wed, 18 Nov 2026 15:28:24 +0100 Message-ID: <20261118142825.100797-2-s.sterz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118142825.100797-1-s.sterz@proxmox.com> References: <20261118142825.100797-1-s.sterz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795012123504 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.558 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: V7GGNDHE7XY52S5RHZVQ75QQFCUJ5P4H X-Message-ID-Hash: V7GGNDHE7XY52S5RHZVQ75QQFCUJ5P4H X-MailFrom: s.sterz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: certain users may want to set stricter permissions than `file_set_contents`'s 0644 default permissions. this change keeps those permissions when modifying the file. Signed-off-by: Shannon Sterz --- src/PVE/Cluster/Setup.pm | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/PVE/Cluster/Setup.pm b/src/PVE/Cluster/Setup.pm index 8a398d3..2550f70 100644 --- a/src/PVE/Cluster/Setup.pm +++ b/src/PVE/Cluster/Setup.pm @@ -157,7 +157,8 @@ sub setup_sshd_config { $conf .= "\nPermitRootLogin yes\n"; } - PVE::Tools::file_set_contents($ssh_system_server_config, $conf); + my $mode = (stat($ssh_system_server_config))[2] & 07777; + PVE::Tools::file_set_contents($ssh_system_server_config, $conf, $mode); PVE::Tools::run_command(['systemctl', 'reload-or-restart', 'sshd']); } -- 2.47.3