From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 2751A1FF0C0 for ; Wed, 18 Nov 2026 15:26:20 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 34F12216A4; Wed, 18 Nov 2026 15:26:13 +0100 (CET) From: Daniel Kral To: pve-devel@lists.proxmox.com Subject: [PATCH ha-manager v3 01/17] resources: remove commented ipaddr resource type Date: Wed, 18 Nov 2026 15:25:40 +0100 Message-ID: <20261118142556.218589-2-d.kral@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118142556.218589-1-d.kral@proxmox.com> References: <20261118142556.218589-1-d.kral@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795011969094 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.551 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: RSJDPWTRMPTZ3VJ6P6KN27Q4CMR6AYN6 X-Message-ID-Hash: RSJDPWTRMPTZ3VJ6P6KN27Q4CMR6AYN6 X-MailFrom: d.kral@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since 85d36c36 ("remove ipaddr resource type") the ipaddr resource type has been commented out, which indicates that it is not intended to be used and should be removed. Even if it might be used in the future, it would need more rework to fit in the current HA stack. Signed-off-by: Daniel Kral Reviewed-by: Michael Köppl Tested-by: Michael Köppl --- src/PVE/HA/Resources.pm | 26 -------------------------- 1 file changed, 26 deletions(-) diff --git a/src/PVE/HA/Resources.pm b/src/PVE/HA/Resources.pm index df7c1ff3..e63d78d8 100644 --- a/src/PVE/HA/Resources.pm +++ b/src/PVE/HA/Resources.pm @@ -189,30 +189,4 @@ sub get_static_stats_from_config { die "implement in subclass"; } -# package PVE::HA::Resources::IPAddr; - -# use strict; -# use warnings; -# use PVE::Tools qw($IPV4RE $IPV6RE); - -# use base qw(PVE::HA::Resources); - -# sub type { -# return 'ipaddr'; -# } - -# sub verify_name { -# my ($class, $name) = @_; - -# die "invalid IP address\n" if $name !~ m!^$IPV6RE|$IPV4RE$!; -# } - -# sub options { -# return { -# state => { optional => 1 }, -# group => { optional => 1 }, -# comment => { optional => 1 }, -# }; -# } - 1; -- 2.47.3