From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0FA001FF0C0 for ; Wed, 18 Nov 2026 14:31:30 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id EB6F021881; Wed, 18 Nov 2026 14:30:06 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v2 manager 15/20] ui: backup now: add overlap option Date: Wed, 18 Nov 2026 14:18:39 +0100 Message-ID: <20261118132947.1093069-16-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118132947.1093069-1-t.lamprecht@proxmox.com> References: <20261118132947.1093069-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1795008592978 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.172 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: IXCCVE2UCFDKJPGVEZUXFBABISTI7DEK X-Message-ID-Hash: IXCCVE2UCFDKJPGVEZUXFBABISTI7DEK X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: An ad-hoc backup runs alone unless the node's vzdump.conf enables 'overlap'. It thus waits for a running job, even if that job allows overlapping and the node has free backup slots. Add the option to the dialog, preset from the node's default, so a single guest can be backed up while a long overlapping job runs. For a node that does not know the option yet, as told by its defaults, the box is disabled and the option left out, as the node would reject the request otherwise. Signed-off-by: Thomas Lamprecht --- new in v2 www/manager6/window/Backup.js | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/www/manager6/window/Backup.js b/www/manager6/window/Backup.js index 0caada651..8adbf938c 100644 --- a/www/manager6/window/Backup.js +++ b/www/manager6/window/Backup.js @@ -123,6 +123,17 @@ Ext.define('PVE.window.Backup', { let initialDefaults = false; + let overlapCheckbox = Ext.create('Proxmox.form.Checkbox', { + name: 'overlap', + checked: false, + uncheckedValue: 0, + fieldLabel: gettext('Overlap'), + autoEl: { + tag: 'div', + 'data-qtip': gettext('Run at the same time as other backups that allow it'), + }, + }); + var storagesel = Ext.create('PVE.form.StorageSelector', { nodename: me.nodename, name: 'storage', @@ -187,6 +198,11 @@ Ext.define('PVE.window.Backup', { mailtoField.setValue(mailto); } } + // nodes that do not know the option yet reject it + overlapCheckbox.setDisabled(data.overlap === undefined); + if (!initialDefaults) { + overlapCheckbox.setValue(!!data.overlap); + } if (!initialDefaults && data.mode !== undefined) { modeSelector.setValue(data.mode); } @@ -249,7 +265,13 @@ Ext.define('PVE.window.Backup', { me.formPanel = Ext.create('Proxmox.panel.InputPanel', { bodyPadding: 10, border: false, - column1: [storagesel, modeSelector, protectedCheckbox, pbsChangeDetection], + column1: [ + storagesel, + modeSelector, + protectedCheckbox, + overlapCheckbox, + pbsChangeDetection, + ], column2: [compressionSelector, notificationModeSelector, mailtoField, removeCheckbox], columnB: [ { @@ -316,6 +338,10 @@ Ext.define('PVE.window.Backup', { remove: values.remove, }; + if (values.overlap !== undefined) { + params.overlap = values.overlap; + } + if (values.mailto) { params.mailto = values.mailto; } -- 2.47.3