From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 0DFB01FF0C0 for ; Wed, 18 Nov 2026 10:46:56 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5EBD52191A; Wed, 18 Nov 2026 10:44:54 +0100 (CET) From: Lukas Wagner To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox v2 36/63] notify: add backwards-compat note to Notification type Date: Wed, 18 Nov 2026 10:43:20 +0100 Message-ID: <20261118094348.273646-37-l.wagner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118094348.273646-1-l.wagner@proxmox.com> References: <20261118094348.273646-1-l.wagner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794995039485 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.195 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZLR75TEDNUDYJ4ZPPAQEM7YHSCYCI47H X-Message-ID-Hash: ZLR75TEDNUDYJ4ZPPAQEM7YHSCYCI47H X-MailFrom: l.wagner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This type will be serialized on disk for the notification queue and later for the notification history, hence any future change must ensure backwards compatibility. Signed-off-by: Lukas Wagner --- proxmox-notify/src/notification.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/proxmox-notify/src/notification.rs b/proxmox-notify/src/notification.rs index b3b93b545..455982c61 100644 --- a/proxmox-notify/src/notification.rs +++ b/proxmox-notify/src/notification.rs @@ -114,6 +114,9 @@ pub struct EmailRecipient { pub author: Option, } +// NOTE: This type is serialized on disk as part of the notification queue and +// notification history, any changes to the type must be kept backwards-compatible (only add +// optional fields or fields which have a default value). #[derive(Debug, Clone, Serialize, Deserialize, PartialEq)] #[serde(rename_all = "kebab-case")] /// Notification which can be sent -- 2.47.3