From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id B7DAA1FF0C0 for ; Wed, 18 Nov 2026 07:54:30 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5BC73216CF; Wed, 18 Nov 2026 07:54:04 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v6 storage 19/42] pvesm: expose the SAN LUN inventory Date: Wed, 18 Nov 2026 07:52:36 +0100 Message-ID: <20261118065302.3033937-20-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261118065302.3033937-1-t.lamprecht@proxmox.com> References: <20261118065302.3033937-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794984788153 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.183 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PGZGD2VUHYA64OMOZFSB632WHIO5PPLD X-Message-ID-Hash: PGZGD2VUHYA64OMOZFSB632WHIO5PPLD X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Dietmar Maurer Add 'pvesm scan san-luns', so that administrators can look at the LUNs of a node with their multipath state, usage and storage on the command line, for example before setting up shared LVM. Signed-off-by: Dietmar Maurer [TL: print a concise column set] Signed-off-by: Thomas Lamprecht --- src/PVE/CLI/pvesm.pm | 14 ++++++++++++++ src/test/run_san_api_tests.pl | 16 ++++++++++++++++ 2 files changed, 30 insertions(+) diff --git a/src/PVE/CLI/pvesm.pm b/src/PVE/CLI/pvesm.pm index 1eb83331..347fbffa 100755 --- a/src/PVE/CLI/pvesm.pm +++ b/src/PVE/CLI/pvesm.pm @@ -736,6 +736,20 @@ our $cmddef = { $print_api_result, $PVE::RESTHandler::standard_output_options, ], + 'san-luns' => [ + "PVE::API2::Storage::Scan", + 'sanlunscan', + [], + { node => $nodename }, + sub { + my ($data, $schema, $options) = @_; + my $columns = + [qw(devpath name size transport state paths-active paths-expected multipath + usage vgname used-by-storage wwid)]; + PVE::CLIFormatter::print_api_result($data, $schema, $columns, $options); + }, + $PVE::RESTHandler::standard_output_options, + ], zfs => [ "PVE::API2::Storage::Scan", 'zfsscan', diff --git a/src/test/run_san_api_tests.pl b/src/test/run_san_api_tests.pl index 4bd7d2d7..5dc433eb 100755 --- a/src/test/run_san_api_tests.pl +++ b/src/test/run_san_api_tests.pl @@ -2,9 +2,11 @@ use strict; use warnings; +use Test::MockModule; use Test::More; use lib qw(. ..); use PVE::API2::Storage::Scan; +use PVE::CLI::pvesm; for my $case (['PVE::API2::Storage::Scan', 'sanlunscan']) { my ($class, @names) = @$case; @@ -21,4 +23,18 @@ for my $case (['PVE::API2::Storage::Scan', 'sanlunscan']) { } } +my $formatter = Test::MockModule->new('PVE::CLIFormatter'); +my $data = [{ wwid => '3600abc', devpath => '/dev/sda', serial => 'S1' }]; +my $schema = PVE::API2::Storage::Scan->map_method_by_name('sanlunscan')->{returns}; +$formatter->mock( + print_api_result => sub { + is($_[0], $data, 'CLI forwards complete rows'); + is($_[1], $schema, 'CLI forwards complete schema'); + ok(grep { $_ eq 'state' } $_[2]->@*, 'CLI shows final state'); + is($_[3]->{'output-format'}, 'json', 'CLI preserves output format'); + }, +); +$PVE::CLI::pvesm::cmddef->{scan}->{'san-luns'}->[4] + ->($data, $schema, { 'output-format' => 'json' }); + done_testing();