From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 6BA041FF0AA for ; Tue, 17 Nov 2026 00:50:44 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 2DEE12160A; Tue, 17 Nov 2026 00:50:39 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794873019; x=1795477819; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=tLlEt5bLKbMK0HM7Olhpy6RXOmL/p+JxFyZlTZygxac=; b=pc8GPTuBrsEjW0MHLXQHeFpakzIJX1XsNDBojcJZFsgTQ6p7eDEOKNXthbZjWaMSRp lnv9d8tbRH4VuMIKcHRDahCZxPB0MNY2EX9XAshlPPxX3+HQf4I2Drj+HpXBmViToaSv 7/LlKAZHkrOzrinMY1oCNUOactfQYeaWT8KQ170RZSUll1cCOnlre3SLRNRHH8XPVwK2 tjg54OZ18gQCgEMjL6xFRgDqlR0gtx6Kq0oU3UpNmlqLQqdI+cP3lhBiAW5/S3T7+Uz8 QwK1wjW7n0Ae7inGrPez3afXekmsrUWyUHku/nXod8mg85Z34DcPzVQI650FFPMjuJHN hHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794873019; x=1795477819; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=tLlEt5bLKbMK0HM7Olhpy6RXOmL/p+JxFyZlTZygxac=; b=JocyDXoWPG6E69P1dJn+NkCEExnZeDzcDbbn9YjQa15vsI2KiQOSzEfabvItXoRmbh d0rnyoL3xcervwFOr4lPUOb5+DOv7pYr5FPzdaz0EHb4yPMvOl7M5eJhLCK6uINffeqd o5ciu4pbB77UwbysinYwDvec76IXCfJWzmHiFA55VRfBDP21BKryC1heVs+5rx6/KCzT /uO2oQLpPyLCP1MFwKdh/X0vdPlLgQdNDQNuBxYb+CsyJRQzQc8w0SczlM56+VUftwL2 jB6Iu/vsZ84ArLOrMdDIyXJvMSc9exx0ZGFbv5ztN8OceUO3wsfcUcBJnApROksMAL9z NBZw== X-Gm-Message-State: APuU4Z9LglNOAHrJSVoVlG9/IUWxkmFGWYcaLNf+4SJ5G6Y5jSiN4Yax jfLmZmiFWT4OubutCcpBGR/qGVmU6GB+P1jFV1kF1DoLEVrp7wC5LjRJ1r2W5hdz X-Gm-Gg: AZFdTZftxj7SvNlDmekjwQDgQV3CzJC/7Su5uGuuz4N1dUBt18Dw0tYEAmhnXAMV1Sk Fk51daVGHXTvmDOQnK91VZJSH8uY+Z3obo6DWdvgImpDpU+gmtOkebr6Db/0sHnAncONn6zTCjW XCWjBroTocwmmqOisOfn+dlsW4EXRoNGjALLvzyed91QqbLSsDzH4BKzLUQ/7H/HDB+MVLHo5y0 57tnb3IRAoroasc9Wa7TATbU9iEkG0YP3+YMw9yv0QBqSLMrjersVU9F69RBjVWV/ne7LptHVMG 93vXwf46eYwGtqvQIhXVyXxM28hTrg4+HWcwPmeSaQTcSZbv3tJAVcDbwesUWvfQoiqd8L4/35U Nh4ZUmbaAvwupD5uwTXIBy3dTM3Wvl+KJTByuixywt7757pHSpbB4fvDgNydo5YE8UJjglGAyWP motyWMjl8tYUWxnwJlB5n5e+2oZtFlIdebZRytYd3FkmYbgm3bMyRmTzA/UB8Go6/nj6BjRHDAf Ey/qqKSY1bvM+gCqyn8dQaqVupXrl6hqho/IdEfO+/a7I7qQ/ClY0gINMQRintBjJO5gQTN7Ofg njGg4ZnPDNZm5N76HruN4ztNCUzevD6t1ENGflZTFd2p X-Received: by 2002:a05:693c:414d:20b0:36c:d1fe:84ce with SMTP id 5a478bee46e88-3796740e475mr13390324eec.33.1794873018857; Mon, 16 Nov 2026 15:50:18 -0800 (PST) From: =?UTF-8?q?=E7=B5=90=E5=8F=8B?= To: t.lamprecht@proxmox.com Subject: Re: [PATCH pve-kernel v4 1/2] d/scripts: correctly compare namespaced ABI exports Date: Tue, 17 Nov 2026 08:50:15 +0900 Message-ID: <20261116235015.31-1-miagetegorann@gmail.com> X-Mailer: git-send-email 2.56.0.windows.4 In-Reply-To: References: <20261024052438.1274-1-miagetegorann@gmail.com> <20261024052438.1274-2-miagetegorann@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.400 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: PHPEKZAML72B3ED7CCEWJ2KGLJFJPRIV X-Message-ID-Hash: PHPEKZAML72B3ED7CCEWJ2KGLJFJPRIV X-MailFrom: miagetegorann@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: pve-devel@lists.proxmox.com X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thanks for the review! > why python tests and not perl, like the script doing the abi export is using? Could be > probably also a simpler array of input, expected tuples to iterate over, but not a must. No good reason. I dropped the tests in v5, see below. > Also, these tests don't really give us any coverage for the real ABI output? if that > diverges (again) we still just miss that? Some actual check and error on unexpected > input above would be probably more helpful. Agreed, the tests are not run by the build, so they would not notice that. The check itself already does though: parse_symbol() dies for every entry matching neither of the two layouts, and the callers die on duplicate symbols. As abicheck runs on the freshly generated file on each build, a diverging format fails the build, e.g.: EE: abi-7.0.14-29-pve-amd64:32728: malformed ABI entry: 'garbage' That is also the case with SKIPABI=1 and in the no-fail mode after an ABI bump, as the comparison cannot be trusted then. If you would rather have it be a warning in those modes, I can change that. While checking this again I noticed that the current parsing is also wrong for more than the VMBus move: for the 2557 namespaced entries it takes the namespace as export type, so a namespaced export changing from EXPORT_SYMBOL to EXPORT_SYMBOL_GPL is not detected. I added that to the commit message. The two layouts come from awk skipping the empty namespace column in abi-generate. I kept reading both in abi-check to avoid regenerating the ABI file, but can instead make abi-generate emit a single layout if you prefer that. I just sent a v5: "[PATCH pve-kernel v5 0/2] fix #8027: restore built-in Hyper-V VMBus"