From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id E67B01FF0BC for ; Mon, 16 Nov 2026 17:31:55 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id A3A88216A3; Mon, 16 Nov 2026 17:31:44 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v5 00/18] ui: split out disks and nics into grids Date: Mon, 16 Nov 2026 17:30:25 +0100 Message-ID: <20261116163138.343821-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.303 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: NUABYIE6FC3AEBC4SJOINDYT36UV4TIA X-Message-ID-Hash: NUABYIE6FC3AEBC4SJOINDYT36UV4TIA X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This splits the disks and nics of the qemu hardware view into their own grids, where each option gets its own column (including pending changes), instead of showing the raw config string in one big list. New in this version is that the series does the same for containers: the volumes (rootfs, mount points, unused disks) get their own grid in the resource view, and the existing network view is converted to show pending changes and then moved into the resource view too, so there is no separate 'Network' panel for containers anymore. For the container network view I tried to keep the existing behavior and code where possible (it still shows the name and addresses from inside the container), so that patch is hopefully easy to compare with what we have now. It differs a bit from the qemu net grid in that it keeps its own toolbar instead of the surrounding view handling the buttons, since it had that before and it does not need anything from the resource view. I tried to keep most commits small so it's easier to see what the actual changes are. NOTE: I took special care for the button enablement logic, but having a close look at that during review would make a lot of sense. That goes for the new container patches as well. Not addressed from the v4 feedback are the horizontal scrollbar topics (overlapping the last row, toolbar not scrolling with the grid), since those are not specific to this series. changes from v4: * rebased on master * new patches to do the same for containers (volumes and nics) * re-added the parser patch for '-' in key names (reverted on master) * pending grid: don't save sorters in the state * pending grid: handle nested columns * pending grid: mark the id of entries with pending changes * pending grid: don't break on properties the parser does not know * config remove button: make the waitMsgTarget configurable * fix the remove button and the storage content selection mid-series * disk grid: fix 'Secure Boot', 'Replicate' and 'Async I/O' columns * net grid: fix the 'Disconnected' column * make the hardware view scrollable * fix sorting of the disk and net grids (e.g. unused disks) * update the buttons when the selected entry changes on a reload * fix the edit button in the general grid and for nics * fix the 'Enroll Updated Certificates' button * show 'Attach' for unused disks and don't allow reassigning tpmstate changes from v3: * rebased on master: - dropped the parser patch (something similar was already applied) - while moving to a container, the selection logic when coming from a storage content panel had to be adapted. changes from v2: * reorganized code/commits for the most part, so it doesn't make much sense to compare it to the previous version changes from v1: * refactor some regexes/checks * fix some bugs I encountered during testing again Dominik Csapak (18): ui: utils: factor out 'media=cdrom' check ui: parser: qemu drive: allow '-' in key name ui: factor out the guest key nic regex check ui: add pending grid ui: revert button: add parentXType and reloadCallback ui: button: add config remove button ui: qemu: hardware: wrap in container ui: qemu: introduce hardware disk grid ui: qemu: introduce hardware net grid ui: qemu: hardware view: separate disks into own grid ui: qemu: hardware view: separate nics into own grid ui: qemu: hardware view: inline edit/remove/revert button in general grid ui: qemu: hardware view: inline 'add efi' menuitem ui: utils: factor out volume size renderer ui: lxc: network view: convert to pending grid ui: lxc: introduce resource volume grid ui: lxc: resources: separate volumes into own grid ui: lxc: resources: integrate network view www/manager6/Makefile | 5 + www/manager6/Parser.js | 2 +- www/manager6/Utils.js | 38 +- www/manager6/button/ConfigRemove.js | 61 ++ www/manager6/button/Revert.js | 8 +- www/manager6/grid/PendingGrid.js | 166 +++++ www/manager6/lxc/Config.js | 6 - www/manager6/lxc/Network.js | 183 +++-- www/manager6/lxc/ResourceVolumeGrid.js | 96 +++ www/manager6/lxc/Resources.js | 582 ++++++++------- www/manager6/qemu/BootOrderEdit.js | 12 +- www/manager6/qemu/CreateWizard.js | 4 +- www/manager6/qemu/HardwareDiskGrid.js | 203 ++++++ www/manager6/qemu/HardwareNetGrid.js | 81 +++ www/manager6/qemu/HardwareView.js | 968 +++++++++++++++---------- www/manager6/window/GuestImport.js | 2 +- 16 files changed, 1691 insertions(+), 726 deletions(-) create mode 100644 www/manager6/button/ConfigRemove.js create mode 100644 www/manager6/grid/PendingGrid.js create mode 100644 www/manager6/lxc/ResourceVolumeGrid.js create mode 100644 www/manager6/qemu/HardwareDiskGrid.js create mode 100644 www/manager6/qemu/HardwareNetGrid.js -- 2.47.3