From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 0F7441FF0E1 for ; Mon, 16 Nov 2026 09:52:34 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 47ACD216CF; Mon, 16 Nov 2026 09:52:29 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v4 2/2] ui: resource tree: only fire 'refresh' event when something changed Date: Mon, 16 Nov 2026 09:51:01 +0100 Message-ID: <20261116085222.993923-2-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261116085222.993923-1-d.csapak@proxmox.com> References: <20261116085222.993923-1-d.csapak@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.307 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: BA2QKAMNCDVP3N2ZV6I4WOVCI3P2JOU2 X-Message-ID-Hash: BA2QKAMNCDVP3N2ZV6I4WOVCI3P2JOU2 X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: to optimize the rendering to the dom, only fire the 'refresh' event of the store at the end of the updateTree method when either: * an element changed its relevant data * something moved * a new element was inserted * an element was removed We also need to refresh the store when the UI options are reloaded, so the tags get the correct color. Signed-off-by: Dominik Csapak --- changes from v3: * rebase on current master * use 'me.store' consistently when firing the 'refresh' event after the UI options were loaded * improve the comment there to say why the refresh is necessary * fix typo in the commit message www/manager6/tree/ResourceTree.js | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js index 3efb1cd3..5d96bffb 100644 --- a/www/manager6/tree/ResourceTree.js +++ b/www/manager6/tree/ResourceTree.js @@ -377,6 +377,7 @@ Ext.define('PVE.tree.ResourceTree', { let updateTree = function () { store.suspendEvents(); + let anyChanged = false; let rootnode; if (firstUpdate) { rootnode = Ext.create('PVETree', { @@ -465,6 +466,7 @@ Ext.define('PVE.tree.ResourceTree', { } me.setIconCls(info); olditem.commit(); + anyChanged = true; } if ((!item || moved) && olditem.isLeaf()) { delete index[key]; @@ -482,6 +484,8 @@ Ext.define('PVE.tree.ResourceTree', { let grandParent = parentNode.parentNode; grandParent.removeChild(parentNode, true); } + + anyChanged = true; } } @@ -501,10 +505,13 @@ Ext.define('PVE.tree.ResourceTree', { if (child) { index[item.data.id] = child; } + anyChanged = true; }); store.resumeEvents(); - store.fireEvent('refresh', store); + if (anyChanged) { + store.fireEvent('refresh', store); + } let foundChild = findNode(rootnode, lastsel?.data.id); @@ -663,6 +670,9 @@ Ext.define('PVE.tree.ResourceTree', { return true; }, }); + + // some nodes need rerendering here, e.g. for tag colors + me.store.fireEvent('refresh', me.store); }); }, }); -- 2.47.3