From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 281761FF09D for ; Sun, 15 Nov 2026 20:42:37 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id B1CC62181F; Sun, 15 Nov 2026 20:41:07 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v2 manager 14/19] ui: token policy: expose the default-to-max-lifetime setting Date: Sun, 15 Nov 2026 20:40:35 +0100 Message-ID: <20261115194043.3947825-15-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261115194043.3947825-1-t.lamprecht@proxmox.com> References: <20261115194043.3947825-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794771649940 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.227 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HU3EV52VQ7KZQJ6GEJIY5OFDIP2U7CF5 X-Message-ID-Hash: HU3EV52VQ7KZQJ6GEJIY5OFDIP2U7CF5 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Render and edit the new setting. It has no effect without a maximum lifetime, so the checkbox is only enabled while one is entered and gets cleared along with it. Signed-off-by: Thomas Lamprecht --- new in v2 www/manager6/dc/OptionView.js | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+) diff --git a/www/manager6/dc/OptionView.js b/www/manager6/dc/OptionView.js index 666be8a52..38b4e8d6e 100644 --- a/www/manager6/dc/OptionView.js +++ b/www/manager6/dc/OptionView.js @@ -401,6 +401,9 @@ Ext.define('PVE.dc.OptionView', { ); parts.push(Ext.String.format(gettext('Max. Lifetime: {0}'), lifetime)); } + if (Number(policy['default-to-max-lifetime'])) { + parts.push(gettext('Default to Max. Lifetime')); + } if (Number(policy['disallow-expiry-extension'])) { parts.push(gettext('Disallow Extending Expiration')); } @@ -446,6 +449,9 @@ Ext.define('PVE.dc.OptionView', { if (me.down('field[name=require-expiry]').getValue()) { policy['require-expiry'] = 1; } + if (values['default-to-max-lifetime']) { + policy['default-to-max-lifetime'] = 1; + } if (values['disallow-expiry-extension']) { policy['disallow-expiry-extension'] = 1; } @@ -500,9 +506,29 @@ Ext.define('PVE.dc.OptionView', { requireExpiry.setValue( implied || !!requireExpiry.explicitValue, ); + let defaultToMax = field + .up('inputpanel') + .down('field[name=default-to-max-lifetime]'); + defaultToMax.setDisabled(!implied); + if (!implied) { + defaultToMax.setValue(false); + } }, }, }, + { + xtype: 'proxmoxcheckbox', + name: 'default-to-max-lifetime', + uncheckedValue: 0, + disabled: true, + fieldLabel: gettext('Default to Max. Lifetime'), + autoEl: { + tag: 'div', + 'data-qtip': gettext( + 'Give tokens created without an expiration date the maximum lifetime instead of rejecting them.', + ), + }, + }, { xtype: 'proxmoxcheckbox', name: 'disallow-expiry-extension', -- 2.47.3