From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 2025B1FF0B7 for ; Fri, 13 Nov 2026 19:44:19 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4CAB1215CB; Fri, 13 Nov 2026 19:44:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20260707; t=1794595441; x=1795200241; darn=lists.proxmox.com; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=durdp5f+tnUaaKZ+tNsclGa1pOMlGyhTezVCipoIs+4=; b=ZZWaKv59TRbVFlM7Y7Hdc2S2SkKnPCy16dsDcPF31OCvJHhR7teafgCdFnM9W5HldX ujjohx5TjNJ2KgfmRO0XLOT5cADDRGjpWlazXzU/0wr8n6b7Zp1yt4oo9k7gdNVttuJU YpWxFRgfk8kXPxeoxsLQiCY/7LdvcewHeorF8209ZE8zU5mf+4k5BM49zgriRRpBf27N M/1OUDLogOcCa2etwxwBqvB6Hiotg0SxRlgnYWb1K/0KSEVAHmQfR0GEgYJvlCWMM7CJ R9eo2y87zNiOKxllRLWNDE4lcVyJLwJn8JAb4u0ZQD+TDFBTQjLusmwENlu3hE/y5ATF TFWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1794595441; x=1795200241; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=durdp5f+tnUaaKZ+tNsclGa1pOMlGyhTezVCipoIs+4=; b=eXQdwKFXSckReWw1JoAnbwpSD7Ou3avJlMFSRLRK7nkjFxZREiv1mPgUB+95m1V49V NLeD+7/3093+/ueaesU6LwzztjfAFNHi6e5tSz4gQcDV9tAoDJg9iilA4fUw2ZSA//WY msbrwxKnjBjylMX01vwuMdZFKvTAPdKuaWu58xxVP80A/45Ca019yGlTpz0T2srX4oTI lfl4WgVBLsm7gNv9HuYErBJhQuT08m1cc9E1XLTtgYbvytAZjltiizkbwnAQ2cw4O2e8 GxtCRJX0yAezRQ8AxkYOBB/CWcjliAxxq/s4/ETG+H/66qjrTvKKah4+zseet4RjmDqP 6xHQ== X-Gm-Message-State: APuU4Z/kxp+A/Cw9+F2BOuWlX2owgVJM6A+NYRqlAte7V8tNgoQU7vqe vYGyUUEuM6aKT0crTOmYcTz3q0CVW5fAwwuqD3bATqzyd6VXDVvdvdsQ X-Gm-Gg: AYBFou3R1Q518aDAUNhmaenUTE/SzsInqVY6MnjookzlUxurtKgB2c0VmrbJunpR2yW TVkNbRYDd5TTuDm+xA6FUBtWs3jB+WrxdWKgPcpZB+IOdJyGEj51QSP2voxZFmLftsgnOAcCneI y/R6a9Deb+cs/1Q1Vuus71+uaMOdQKrvwIoxFTXgjsv3/lw9PeQXiZluFLORAzKW9uUD9Xaq7qT 9gwER2odzaQfaf8iREJvrc7acyidPS+p0s9wiWZpPZbwNR05twFm5lmlOX188WXK/+e/PZbkOTC xRzqyKXPeD2DpM3d4iNKBagpPrGho7XmAQDE8lm8inQQvBl1pT73kLi+yGpeQP5PfCaShN0NBMU E/3Yo7P0R4Zfq/GibgK8UoBZ1N5oXkpUNaXH7Zr1lleqa0HQVYjT3+GM8JQvdZBS5PoLQxsuQNt 7Eh19QTkHiBkFz9NllgO2eSYOXh+5yMdIxn8SyHKPD9BmfohhigCqda8z/eHjMO9LfEEED5teTS YhvvDimSJIFbnOhYUl6D5sjkzizB59e0K8uv5xSCzCQdtmPsDsf5XMDj92443Rs3P+rpsPE9uXB L0hVkxC2WVVnmC2scSDRVIxF X-Received: by 2002:a05:690e:12c6:b0:677:dae6:51d4 with SMTP id 956f58d0204a3-67d8989bc1dmr2459481d50.106.1794595441363; Fri, 13 Nov 2026 10:44:01 -0800 (PST) From: Ciro Iriarte To: pve-devel@lists.proxmox.com Subject: Re: [PATCH storage] btrfs: fix clone_image cloning live data instead of the requested snapshot Date: Fri, 13 Nov 2026 15:43:56 -0300 Message-ID: <20261113.btrfsclonesnapfix.ping@cyruspy.gmail.com> In-Reply-To: <20260907.btrfsclonesnapfix@cyruspy.gmail.com> References: <20260907.btrfsclonesnapfix@cyruspy.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.104 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy FREEMAIL_FROM 0.001 Sender email is commonly abused enduser mail provider RCVD_IN_DNSWL_NONE -0.0001 Sender listed at https://www.dnswl.org/, no trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ETOK5MU2YZ7EOGSXVWDKLBOOLBETNEWE X-Message-ID-Hash: ETOK5MU2YZ7EOGSXVWDKLBOOLBETNEWE X-MailFrom: cyruspy@gmail.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Ping. This patch is independent of the copy-offload series. BTRFSPlugin::clone_image() accepts $snap but never passes it to filesystem_path(), so it always clones the live subvolume. As a result, linked-cloning a raw disk from a snapshot on btrfs storage silently produces a disk with the current data instead of the snapshot's. It is reachable through the clone API with full=0 and snapname, e.g. qm clone --full 0 --snapname . The commit message overstates this: the GUI does not offer that combination. The bug is still present on current master (76a5d40), and the patch still applies cleanly. It is filed as bug #8156.