From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 4B22A1FF0B6 for ; Thu, 12 Nov 2026 15:12:12 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9786E21681; Thu, 12 Nov 2026 15:12:08 +0100 (CET) From: Filip Schauer To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox 02/26] oci: rename error when no manifest can be selected Date: Thu, 12 Nov 2026 15:10:29 +0100 Message-ID: <20261112141109.137298-3-f.schauer@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261112141109.137298-1-f.schauer@proxmox.com> References: <20261112141109.137298-1-f.schauer@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794492725457 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.244 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WMQWTASYEZ43BONHLQJHNY6ZQWVINSXC X-Message-ID-Hash: WMQWTASYEZ43BONHLQJHNY6ZQWVINSXC X-MailFrom: f.schauer@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Selecting an image manifest from the image index can fail for reasons other than the CPU architecture. Signed-off-by: Filip Schauer --- proxmox-oci/src/lib.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/proxmox-oci/src/lib.rs b/proxmox-oci/src/lib.rs index 78045f49..0e732324 100644 --- a/proxmox-oci/src/lib.rs +++ b/proxmox-oci/src/lib.rs @@ -136,8 +136,8 @@ pub enum ParseError { WrongMediaType, #[error("IO error: {0}")] Io(#[from] io::Error), - #[error("Unsupported CPU architecture")] - UnsupportedArchitecture, + #[error("No image manifest found in image index for the requested platform")] + NoMatchingManifest, #[error("Missing image config")] MissingImageConfig, } @@ -151,7 +151,7 @@ fn parse_image>( let image_manifest = oci_tar_image .image_manifest(arch) - .ok_or(ParseError::UnsupportedArchitecture)??; + .ok_or(ParseError::NoMatchingManifest)??; let image_config_descriptor = image_manifest.config(); -- 2.47.3