From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 840741FF0B6 for ; Thu, 12 Nov 2026 10:46:01 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 978AF217C6; Thu, 12 Nov 2026 10:44:53 +0100 (CET) From: Dominik Rusovac To: pve-devel@lists.proxmox.com Subject: [PATCH pve-ha-manager v2 13/19] manager: remove obsolete argument Date: Thu, 12 Nov 2026 10:44:31 +0100 Message-ID: <20261112094437.1951271-14-d.rusovac@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261112094437.1951271-1-d.rusovac@proxmox.com> References: <20261112094437.1951271-1-d.rusovac@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794476686150 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.040 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 2ODRXVWGUVEPQ2LAZBHYA7OJVPNDBTSW X-Message-ID-Hash: 2ODRXVWGUVEPQ2LAZBHYA7OJVPNDBTSW X-MailFrom: d.rusovac@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Respective parameter was removed. Fixes: c087c06 ("remove redundant service_node and migration_target parameter") Reviewed-by: Daniel Kral Signed-off-by: Dominik Rusovac --- Notes: changes since v1: * reword commit * reference the commit with a Fixes: trailer instead of the lore link * add daniel's r-b src/PVE/HA/Manager.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/HA/Manager.pm b/src/PVE/HA/Manager.pm index 5840a76..7a5a685 100644 --- a/src/PVE/HA/Manager.pm +++ b/src/PVE/HA/Manager.pm @@ -385,7 +385,7 @@ sub select_service_node { return $current_node if $node_preference eq 'none' && $pri_nodes->{$current_node}; - my $scores = $online_node_usage->score_nodes_to_start_service($sid, $current_node); + my $scores = $online_node_usage->score_nodes_to_start_service($sid); my @nodes = sort { $scores->{$a} <=> $scores->{$b} || $a cmp $b } keys %$pri_nodes; -- 2.47.3