From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id AFBCB1FF0B3 for ; Wed, 11 Nov 2026 14:52:44 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 5CC8F21689; Wed, 11 Nov 2026 14:52:41 +0100 (CET) From: Dominik Csapak To: pve-devel@lists.proxmox.com Subject: [RFC PATCH qemu-server] config: watchdog: remove unusable model Date: Wed, 11 Nov 2026 14:49:36 +0100 Message-ID: <20261111135237.2666585-1-d.csapak@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.309 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WNOGTXOQ2LIMZ4Y5F3H6VJFHQ3O25EVG X-Message-ID-Hash: WNOGTXOQ2LIMZ4Y5F3H6VJFHQ3O25EVG X-MailFrom: d.csapak@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since commit 0a40e8ea (fix watchdog pci addr) from 2011 (!), the `ib700` model of the virtual watchdog hardware was unusable, since we always want to attach it to a pci bus, but that model is an ISA variant so QEMU fails to start with: kvm: -device ib700,bus=pci.0,addr=0x4: Device 'ib700' can't go on PCI bus Instead of trying to fix it, just remove this model, since there was no report in the last 15 years, so nobody seems to be interested in it. The default model is a PCI variant, so this works as expected. Signed-off-by: Dominik Csapak --- i didn't add a "Fixes" trailer on purpose, since it does not "fix" a commit in the normal sense, but prevents configuring non-working settings. src/PVE/QemuServer.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 005fcb6e..55abde5e 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -147,7 +147,7 @@ my $watchdog_fmt = { model => { default_key => 1, type => 'string', - enum => [qw(i6300esb ib700)], + enum => [qw(i6300esb)], description => "Watchdog type to emulate.", default => 'i6300esb', optional => 1, -- 2.47.3