From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 623711FF09B for ; Mon, 09 Nov 2026 16:44:22 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9F32D216A6; Mon, 09 Nov 2026 16:43:51 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH container 4/4] pct: resize: propagate exit status from worker Date: Mon, 9 Nov 2026 16:39:37 +0100 Message-ID: <20261109154341.215638-5-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261109154341.215638-1-f.ebner@proxmox.com> References: <20261109154341.215638-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1794239025126 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.286 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: ZHB32MCYAFCOVMSEP5ZJOT4WYVVSHMLI X-Message-ID-Hash: ZHB32MCYAFCOVMSEP5ZJOT4WYVVSHMLI X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Commit 9f3f796 ("Start a worker in lxc resize.") changed the 'resize_vm' API endpoint to return a worker UPID, but forgot to adapt the related 'pct' CLI invocation, which then always returned success if it reached the point of forking the worker. Fix this and propagate the exit status from that worker. Fixes: 9f3f796 ("Start a worker in lxc resize.") Signed-off-by: Fiona Ebner --- src/PVE/CLI/pct.pm | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/PVE/CLI/pct.pm b/src/PVE/CLI/pct.pm index ceb0bea..8c210a0 100755 --- a/src/PVE/CLI/pct.pm +++ b/src/PVE/CLI/pct.pm @@ -1102,7 +1102,13 @@ our $cmddef = { ], set => ['PVE::API2::LXC::Config', 'update_vm', ['vmid'], { node => $nodename }], - resize => ["PVE::API2::LXC", 'resize_vm', ['vmid', 'disk', 'size'], { node => $nodename }], + resize => [ + "PVE::API2::LXC", + 'resize_vm', + ['vmid', 'disk', 'size'], + { node => $nodename }, + $upid_exit, + ], create => ['PVE::API2::LXC', 'create_vm', ['vmid', 'ostemplate'], { node => $nodename }, $upid_exit], -- 2.47.3