From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id BA5A61FF0AF for ; Fri, 06 Nov 2026 16:48:07 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 9300E217D8; Fri, 06 Nov 2026 16:47:00 +0100 (CET) From: "Max R. Carrara" To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v4 15/17] ui: storage view: display error when no editor for storage type exists Date: Fri, 6 Nov 2026 16:45:51 +0100 Message-ID: <20261106154554.2182986-16-m.carrara@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261106154554.2182986-1-m.carrara@proxmox.com> References: <20261106154554.2182986-1-m.carrara@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793979986393 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.322 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: N4OOLKUFT6NHAYVBXSU6G53PGNDA3MZH X-Message-ID-Hash: N4OOLKUFT6NHAYVBXSU6G53PGNDA3MZH X-MailFrom: m.carrara@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Alfonso Kuen , Thomas Ellmenreich , Jakob Klocker X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: ... instead of `throw`ing an exception which gets swallowed by ExtJS and never displayed to the user. Signed-off-by: Max R. Carrara --- www/manager6/dc/StorageView.js | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/www/manager6/dc/StorageView.js b/www/manager6/dc/StorageView.js index e4c6f07d..e779e9c4 100644 --- a/www/manager6/dc/StorageView.js +++ b/www/manager6/dc/StorageView.js @@ -11,11 +11,18 @@ Ext.define( stateId: 'grid-dc-storage', createStorageEditWindow: function (type, sid) { let schema = PVE.Utils.storageSchema[type]; if (!schema || !schema.ipanel) { - throw 'no editor registered for storage type: ' + type; + Ext.Msg.alert( + gettext('Error'), + Ext.String.format( + gettext("No editor registered for storage type '{0}'"), + Ext.htmlEncode(type), + ), + ); + return; } Ext.create('PVE.storage.BaseEdit', { paneltype: 'PVE.storage.' + schema.ipanel, type: type, -- 2.47.3