From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <pve-devel-bounces@lists.proxmox.com>
Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40])
	by lore.proxmox.com (Postfix) with ESMTPS id 24AE01FF0AF
	for <inbox@lore.proxmox.com>; Fri, 06 Nov 2026 14:15:35 +0100 (CET)
Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1])
	by gate001.proxmox.com (Proxmox) with ESMTP id 44820215BA;
	Fri, 06 Nov 2026 14:15:23 +0100 (CET)
From: Kefu Chai <k.chai@proxmox.com>
To: m.koeppl@proxmox.com
Subject: Re: [PATCH e2e-tests 29/38] tests: ceph: verify replacing an OSD
Date: Fri,  6 Nov 2026 21:14:27 +0800
Message-ID: <20261106131427.270787-1-k.chai@proxmox.com>
X-Mailer: git-send-email 2.47.3
In-Reply-To: <20261104190345.2573464-30-m.koeppl@proxmox.com>
References: <20261104190345.2573464-1-m.koeppl@proxmox.com>
 <20261104190345.2573464-30-m.koeppl@proxmox.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2
X-Bm-Transport-Timestamp: 1793970872129
X-SPAM-LEVEL: Spam detection results:  0
	AWL                     0.237 Adjusted score from AWL reputation of From:
 address
	DMARC_MISSING             0.1 Missing DMARC policy
	KAM_DMARC_STATUS         0.01 Test Rule for DKIM or SPF Failure with Strict
 Alignment (newer systems)
	RCVD_IN_DNSWL_MED        -2.3 Sender listed at https://www.dnswl.org/,
 medium trust
	SPF_HELO_NONE           0.001 SPF: HELO does not publish an SPF Record
	SPF_PASS               -0.001 SPF: sender matches SPF record
Message-ID-Hash: N7VL7225QIIEHZH3AEETPWTEGAPLAVAK
X-Message-ID-Hash: N7VL7225QIIEHZH3AEETPWTEGAPLAVAK
X-MailFrom: k.chai@proxmox.com
X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop;
 banned-address; emergency; member-moderation; nonmember-moderation;
 administrivia; implicit-dest; max-recipients; max-size; news-moderation;
 no-subject; digests; suspicious-header
CC: pve-devel@lists.proxmox.com
X-Mailman-Version: 3.3.10
Precedence: list
List-Id: Proxmox VE development discussion <pve-devel.lists.proxmox.com>
List-Help: <mailto:pve-devel-request@lists.proxmox.com?subject=help>
List-Owner: <mailto:pve-devel-owner@lists.proxmox.com>
List-Post: <mailto:pve-devel@lists.proxmox.com>
List-Subscribe: <mailto:pve-devel-join@lists.proxmox.com>
List-Unsubscribe: <mailto:pve-devel-leave@lists.proxmox.com>

Hi Michael,

> [snip]
> +            $first->start_guest('lxc', $ctid);
> +            $first->ct_exec($ctid, "sh -c 'echo $marker > /root/marker'");
> [snip]

Could we sync the marker before replacing the OSD, then stop/start
the container and read it again after the "kept running" check?
PVE's stop cleanup unmounts the root filesystem and unmaps its RBD
device, so the final read would no longer use the old filesystem's
page cache.

> [snip]
> +        my $upid = $osd_client->delete("/nodes/$osd_node/ceph/osd/$id", { cleanup => 1 });
> +        $second->task_ok($upid, "destroyed osd.$id") or die "destroying osd.$id failed\n";
> [snip]

Could we also check cmd-safety with action=destroy before this?
The earlier action=stop checks ok-to-stop; action=destroy would
cover the safe-to-destroy check as well.