From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 1F2331FF0AF for ; Fri, 06 Nov 2026 01:57:48 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 21A5E21D72; Fri, 06 Nov 2026 01:51:19 +0100 (CET) From: Thomas Lamprecht To: pve-devel@lists.proxmox.com Subject: [PATCH v3 manager 62/76] pvestatd: apply the multipath configuration and report the node status Date: Fri, 6 Nov 2026 00:31:37 +0100 Message-ID: <20261105233336.2178064-63-t.lamprecht@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261105233336.2178064-1-t.lamprecht@proxmox.com> References: <20261105233336.2178064-1-t.lamprecht@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793926181773 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.303 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QRTFJTT7PFR5B4ACMZ6FQHEEMHBJARZ2 X-Message-ID-Hash: QRTFJTT7PFR5B4ACMZ6FQHEEMHBJARZ2 X-MailFrom: t.lamprecht@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Use pvestatd's periodic loop to apply multipath configuration and publish node health, including after reboots and storage changes. Run this before node, guest, and storage status updates so a slow update does not delay the first report of a path outage. Nodes without multipath-tools send only a small report, resent once a minute while unchanged. With the tools, daemon availability is checked on every pass; without managed LUNs, a successful map listing is reused for a minute. Log configuration errors when they first occur, not on every pass. Signed-off-by: Thomas Lamprecht --- PVE/Service/pvestatd.pm | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/PVE/Service/pvestatd.pm b/PVE/Service/pvestatd.pm index f682c2f9d..4218db2e7 100755 --- a/PVE/Service/pvestatd.pm +++ b/PVE/Service/pvestatd.pm @@ -21,6 +21,8 @@ use PVE::NodeConfig; use PVE::Cluster qw(cfs_read_file); use PVE::Storage; use PVE::Storage::StatusCommand; +use PVE::Multipath::Generator; +use PVE::Multipath::Status; use PVE::QemuServer; use PVE::QemuServer::Monitor; use PVE::LXC; @@ -808,6 +810,17 @@ my sub broadcast_version_info : prototype() { } } +my $last_multipath_sync_error = ''; +my sub update_multipath_status : prototype() { + my $multipath = eval { PVE::Multipath::Generator::sync(); }; + $multipath = { error => $@ } if $@; + my $sync_error = $multipath->{error} // ''; + syslog('err', "multipath config sync error: $sync_error") + if $sync_error ne '' && $sync_error ne $last_multipath_sync_error; + $last_multipath_sync_error = $sync_error; + PVE::Multipath::Status::broadcast_status($multipath); +} + sub update_status { # update worker list. This is not really required, but we want to make sure that we also have a # correct list in case of an unexpected crash. @@ -824,6 +837,12 @@ sub update_status { my $status_cfg = PVE::Cluster::cfs_read_file('status.cfg'); + # apply the multipath configuration before the other updates: the storage status update can + # block in LVM while all paths of a LUN are lost + eval { update_multipath_status(); }; + $err = $@; + syslog('err', "multipath status broadcast error: $err") if $err; + eval { update_node_status($status_cfg, $pull_txn); }; $err = $@; syslog('err', "node status update error: $err") if $err; -- 2.47.3