From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 297B81FF0DF for ; Thu, 05 Nov 2026 10:41:35 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 935132147A; Thu, 05 Nov 2026 10:41:33 +0100 (CET) From: Lukas Sichert To: pve-devel@lists.proxmox.com Subject: [PATCH perl-rs/proxmox v2 0/3] perl: enable strict and warnings in modules that lack them Date: Thu, 5 Nov 2026 10:41:01 +0100 Message-ID: <20261105094124.42373-1-l.sichert@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793871690135 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.480 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: 5U3FZJEZQZHPOD733AZG6IAPS376FWGK X-Message-ID-Hash: 5U3FZJEZQZHPOD733AZG6IAPS376FWGK X-MailFrom: l.sichert@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Lukas Sichert X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: A scan of the perl modules in these repositories found a few that enable neither 'use v5.36' nor 'use strict' and 'use warnings'. Enable them to adhere to the style guide and so that mistakes such as typos in variable names or uses of undefined values do not go unnoticed. The Fixup.pm files in pve-rs and pmg-rs are intentionally left alone. They are not modules of their own, but snippets that perlmod's genpackage.pl inserts into the generated Proxmox::Lib::PVE and Proxmox::Lib::PMG right after the 'use strict; use warnings;' of its template, so they already run under both pragmas. Testing: - proxmox: running 'make refresh' in pve-api-types before and after the change generates identical output and identical stderr. - perl-rs: syntax check and including the common file with perl -e returned no warnings Changes v1 -> v2: - removed the pve-network patch as it is already applied - deleted the CalendarEvent files instead of enabling strict and warnings - enable v5.36 instead of strict and warnings in proxmox perl-rs: Lukas Sichert (2): common: remove deprecated PVE::RS::CalendarEvent compat module common: enable v5.36 in Proxmox::Lib::Common common/pkg/PVE/RS/CalendarEvent.pm | 3 --- common/pkg/Proxmox/Lib/Common.pm | 2 ++ 2 files changed, 2 insertions(+), 3 deletions(-) delete mode 100644 common/pkg/PVE/RS/CalendarEvent.pm proxmox: Lukas Sichert (1): pve-api-types: enable v5.36 in Bool pve-api-types/generator-lib/Bool.pm | 2 ++ 1 file changed, 2 insertions(+) Summary over all repositories: 3 files changed, 4 insertions(+), 3 deletions(-) -- Generated by murpp 0.12.0