From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id C01501FF0C0 for ; Wed, 04 Nov 2026 20:05:18 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 42B202176C; Wed, 04 Nov 2026 20:04:01 +0100 (CET) From: =?UTF-8?q?Michael=20K=C3=B6ppl?= To: pve-devel@lists.proxmox.com Subject: [PATCH e2e-tests 08/38] lib: pveinstance: add helpers to start and stop guests Date: Wed, 4 Nov 2026 20:03:15 +0100 Message-ID: <20261104190345.2573464-9-m.koeppl@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261104190345.2573464-1-m.koeppl@proxmox.com> References: <20261104190345.2573464-1-m.koeppl@proxmox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793819033950 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.220 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: OCZMJAXTU62BGR446EKVWIRU3OE7T5VN X-Message-ID-Hash: OCZMJAXTU62BGR446EKVWIRU3OE7T5VN X-MailFrom: m.koeppl@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Most tests start or stop a guest at some point and need to check that the task succeeded that the guest reports status 'running' after a start. Without a shared helper, each test has to repeat this. Add start_guest() and stop_guest() for both VMs and containers, which record the task result as a test point and die if it failed. Signed-off-by: Michael Köppl --- Proxmox/Test/PVEInstance.pm | 36 ++++++++++++++++++++++++++++++++++++ 1 file changed, 36 insertions(+) diff --git a/Proxmox/Test/PVEInstance.pm b/Proxmox/Test/PVEInstance.pm index 646ff48..957e3e7 100644 --- a/Proxmox/Test/PVEInstance.pm +++ b/Proxmox/Test/PVEInstance.pm @@ -51,6 +51,42 @@ sub get_additional_disks { return $self->{config}->{additional_disks}; } +my $guest_label = sub { + my ($type) = @_; + return $type eq 'qemu' ? 'VM' : 'container'; +}; + +# Start a guest and assert that the start task succeeded. Dies if it failed or if the guest does not +# report status 'running' afterwards. $type can either be 'qemu' or 'lxc'. +sub start_guest { + my ($self, $type, $vmid) = @_; + + my $client = $self->client(); + my $path = "/nodes/" . $self->get_nodename() . "/$type/$vmid"; + my $label = $guest_label->($type); + + my $upid = $client->post("$path/status/start", {}); + $self->task_ok($upid, "started $label $vmid") or die "starting $label $vmid failed\n"; + + poll_until( + sub { $client->get("$path/status/current", {})->{status} eq 'running' }, + timeout => 120, + description => "$label $vmid to report status 'running'", + ); +} + +# Stop a guest and assert that the stop task succeeded. Dies if it failed. $type can either be +# 'qemu' or 'lxc'. +sub stop_guest { + my ($self, $type, $vmid) = @_; + + my $path = "/nodes/" . $self->get_nodename() . "/$type/$vmid"; + my $label = $guest_label->($type); + + my $upid = $self->client()->post("$path/status/stop", {}); + $self->task_ok($upid, "stopped $label $vmid") or die "stopping $label $vmid failed\n"; +} + sub destroy_guest { my ($self, $type, $vmid) = @_; return $self->destroy_guest_on($self->get_nodename(), $type, $vmid); -- 2.47.3