From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 26AEF1FF0C0 for ; Wed, 04 Nov 2026 17:05:09 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id CF77E213DC; Wed, 04 Nov 2026 17:05:06 +0100 (CET) From: Stefan Hanreich To: pve-devel@lists.proxmox.com Subject: [PATCH pve-common 1/1] network: interfaces: add guard for substitution in slaves property Date: Wed, 4 Nov 2026 17:04:54 +0100 Message-ID: <20261104160456.447514-1-s.hanreich@proxmox.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793808303357 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.323 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: XCNG7UHTVKSDATFXPAFRIQUVK6WUANER X-Message-ID-Hash: XCNG7UHTVKSDATFXPAFRIQUVK6WUANER X-MailFrom: s.hanreich@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Otherwise bonds with no slaves defined will trigger a perl warning that substition is performed on an undefined variable. Signed-off-by: Stefan Hanreich --- src/PVE/Network/Interfaces.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/PVE/Network/Interfaces.pm b/src/PVE/Network/Interfaces.pm index ad4d837..19d5b08 100644 --- a/src/PVE/Network/Interfaces.pm +++ b/src/PVE/Network/Interfaces.pm @@ -647,7 +647,7 @@ sub __interface_to_string($iface, $d, $family, $first_block, $ifupdown2 = undef) } elsif ($d->{type} eq 'bond') { - $d->{slaves} =~ s/[;,\s]+/ /g; + $d->{slaves} =~ s/[;,\s]+/ /g if $d->{slaves}; my $slaves = $d->{slaves} || 'none'; $raw .= "\tbond-slaves $slaves\n"; $done->{slaves} = 1; -- 2.47.3