From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 1FE401FF0AA for ; Tue, 03 Nov 2026 09:46:48 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id F23D821A8C; Tue, 03 Nov 2026 09:44:37 +0100 (CET) From: Arthur Bied-Charreton To: pve-devel@lists.proxmox.com Subject: [PATCH pve-manager v5 26/27] ui: firewall: show the task for reference updates Date: Tue, 3 Nov 2026 09:43:27 +0100 Message-ID: <20261103084328.203492-27-a.bied-charreton@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261103084328.203492-1-a.bied-charreton@proxmox.com> References: <20261103084328.203492-1-a.bied-charreton@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793695420502 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.728 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: WLPUJJBP56YDAZXBMNX3LRLPQWQU23P5 X-Message-ID-Hash: WLPUJJBP56YDAZXBMNX3LRLPQWQU23P5 X-MailFrom: a.bied-charreton@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Renaming or deleting an ipset or alias returns a UPID. Open the task progress window and reload the grid once the task has finished. Both dialogs only open that window if a UPID is returned, so the requests that are still answered synchronously (a plain create or an edit that only changes a comment) are not affected. Also add display names for the four task types. Signed-off-by: Arthur Bied-Charreton --- www/manager6/Utils.js | 4 ++++ www/manager6/grid/FirewallAliases.js | 4 ++++ www/manager6/grid/FirewallObjectCommon.js | 2 ++ www/manager6/panel/IPSet.js | 4 ++++ 4 files changed, 14 insertions(+) diff --git a/www/manager6/Utils.js b/www/manager6/Utils.js index 8b99371d..9ec3951a 100644 --- a/www/manager6/Utils.js +++ b/www/manager6/Utils.js @@ -2194,6 +2194,10 @@ Ext.define('PVE.Utils', { dircreate: [gettext('Directory Storage'), gettext('Create')], dirremove: [gettext('Directory'), gettext('Remove')], download: [gettext('File'), gettext('Download')], + 'fw-alias-delete': [gettext('Firewall Alias'), gettext('Delete')], + 'fw-alias-rename': [gettext('Firewall Alias'), gettext('Rename')], + 'fw-ipset-delete': [gettext('Firewall IPSet'), gettext('Delete')], + 'fw-ipset-rename': [gettext('Firewall IPSet'), gettext('Rename')], hamigrate: ['HA', gettext('Migrate')], hashutdown: ['HA', gettext('Shutdown')], hastart: ['HA', gettext('Start')], diff --git a/www/manager6/grid/FirewallAliases.js b/www/manager6/grid/FirewallAliases.js index 06dc3b9c..de8a92eb 100644 --- a/www/manager6/grid/FirewallAliases.js +++ b/www/manager6/grid/FirewallAliases.js @@ -7,6 +7,9 @@ Ext.define('PVE.FirewallAliasEdit', { width: 400, + // a rename that updates references comes back as a task + showProgress: true, + onlineHelp: 'pve_firewall_dangling_references', initComponent: function () { @@ -242,6 +245,7 @@ Ext.define('PVE.FirewallAliases', { }, ], apiCallDone: reload, + taskDone: reload, }).show(); }, }); diff --git a/www/manager6/grid/FirewallObjectCommon.js b/www/manager6/grid/FirewallObjectCommon.js index 04dddf48..0b912650 100644 --- a/www/manager6/grid/FirewallObjectCommon.js +++ b/www/manager6/grid/FirewallObjectCommon.js @@ -4,6 +4,8 @@ Ext.define('PVE.window.FirewallObjectRemove', { width: 500, + showProgress: true, + // [{ value, text, description }, ...] referenceActions: undefined, diff --git a/www/manager6/panel/IPSet.js b/www/manager6/panel/IPSet.js index 40c1ef4b..b2438ce1 100644 --- a/www/manager6/panel/IPSet.js +++ b/www/manager6/panel/IPSet.js @@ -125,7 +125,10 @@ Ext.define('PVE.IPSetList', { url: me.base_url, method: 'POST', digest: rec.data.digest, + // a rename that updates references comes back as a task + showProgress: true, onlineHelp: 'pve_firewall_dangling_references', + items: [ipanel], }); win.show(); @@ -201,6 +204,7 @@ Ext.define('PVE.IPSetList', { }, ], apiCallDone: reload, + taskDone: reload, }).show(); }, }); -- 2.47.3