From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 45E3B1FF09C for ; Mon, 02 Nov 2026 13:46:05 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 4D06B21756; Mon, 02 Nov 2026 13:45:54 +0100 (CET) From: Christoph Heiss To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox v4 01/30] installer-types: clippy: use .is_multiple_of() instead of manual modulo Date: Mon, 2 Nov 2026 13:45:07 +0100 Message-ID: <20261102124539.1008075-2-c.heiss@proxmox.com> X-Mailer: git-send-email 2.55.0 In-Reply-To: <20261102124539.1008075-1-c.heiss@proxmox.com> References: <20261102124539.1008075-1-c.heiss@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793623550134 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.233 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: QUZKTHIDPWP6UEEJ5CJXZVE4SQVIZMCD X-Message-ID-Hash: QUZKTHIDPWP6UEEJ5CJXZVE4SQVIZMCD X-MailFrom: c.heiss@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Fixes the following clippy warning: https://rust-lang.github.io/rust-clippy/rust-1.94.0/index.html#manual_is_multiple_of Signed-off-by: Christoph Heiss --- Changes v3 -> v4: * no changes Changes v2 -> v3: * new patch proxmox-installer-types/src/answer.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/proxmox-installer-types/src/answer.rs b/proxmox-installer-types/src/answer.rs index 5d9b3953..9375989d 100644 --- a/proxmox-installer-types/src/answer.rs +++ b/proxmox-installer-types/src/answer.rs @@ -764,7 +764,7 @@ impl DiskSetup { raid.min_disks(), ); } - if raid.requires_even_disks() && n % 2 != 0 { + if raid.requires_even_disks() && !n.is_multiple_of(2) { bail!("ZFS {raid} needs an even number of disks, got {n}"); } } @@ -793,7 +793,7 @@ impl DiskSetup { raid.min_disks(), ); } - if raid.requires_even_disks() && n % 2 != 0 { + if raid.requires_even_disks() && !n.is_multiple_of(2) { bail!("Btrfs {raid} needs an even number of disks, got {n}"); } } -- 2.55.0