From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id F20101FF0B7 for ; Fri, 30 Oct 2026 14:25:50 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 175112164F; Fri, 30 Oct 2026 14:25:41 +0100 (CET) From: Elias Huhsovitz To: pve-devel@lists.proxmox.com Subject: [PATCH proxmox-perl-rs v2 3/3] makefile: use UPLOAD_DIST variable Date: Fri, 30 Oct 2026 14:25:33 +0100 Message-ID: <20261030132533.150795-4-e.huhsovitz@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261030132533.150795-1-e.huhsovitz@proxmox.com> References: <20261030132533.150795-1-e.huhsovitz@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793366736548 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.453 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: DI3PB3UKLPELRFGGOCG4R23A7KJ6T7H5 X-Message-ID-Hash: DI3PB3UKLPELRFGGOCG4R23A7KJ6T7H5 X-MailFrom: e.huhsovitz@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Elias Huhsovitz X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The variable UPLOAD_DIST is never used in the upload target. Utilize the UPLOAD_DIST variable. This mirrors the design of the proxmox-backup Makefile and unties the upload dist name from the debian dist name. Signed-off-by: Elias Huhsovitz --- common/pkg/Makefile | 2 +- pmg-rs/Makefile | 2 +- pve-rs/Makefile | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/common/pkg/Makefile b/common/pkg/Makefile index 5a537f9..1e63bfa 100644 --- a/common/pkg/Makefile +++ b/common/pkg/Makefile @@ -69,7 +69,7 @@ upload: UPLOAD_DIST ?= $(DEB_DISTRIBUTION) upload: $(DEB) # check if working directory is clean git diff --exit-code --stat && git diff --exit-code --stat --staged - tar cf - $(DEB) | ssh -X repoman@repo.proxmox.com upload --product pve,pmg --dist $(DEB_DISTRIBUTION) + tar cf - $(DEB) | ssh -X repoman@repo.proxmox.com upload --product pve,pmg --dist $(UPLOAD_DIST) clean: rm -f *.deb *.dsc *.tar.* *.build *.buildinfo *.changes diff --git a/pmg-rs/Makefile b/pmg-rs/Makefile index 5025aae..f5d31a2 100644 --- a/pmg-rs/Makefile +++ b/pmg-rs/Makefile @@ -95,7 +95,7 @@ upload: UPLOAD_DIST ?= $(DEB_DISTRIBUTION) upload: $(DEBS) # check if working directory is clean git diff --exit-code --stat && git diff --exit-code --stat --staged - tar cf - $(DEBS) | ssh -X repoman@repo.proxmox.com upload --product pmg --dist $(DEB_DISTRIBUTION) + tar cf - $(DEBS) | ssh -X repoman@repo.proxmox.com upload --product pmg --dist $(UPLOAD_DIST) $(BUILDDIR): src debian common/src Cargo.toml rustfmt.toml Makefile .cargo/config.toml Fixup.pm rm -rf $(BUILDDIR) $(BUILDDIR).tmp diff --git a/pve-rs/Makefile b/pve-rs/Makefile index 3ae66c1..f9ba49c 100644 --- a/pve-rs/Makefile +++ b/pve-rs/Makefile @@ -112,7 +112,7 @@ upload: UPLOAD_DIST ?= $(DEB_DISTRIBUTION) upload: $(DEBS) # check if working directory is clean git diff --exit-code --stat && git diff --exit-code --stat --staged - tar cf - $(DEBS) | ssh -X repoman@repo.proxmox.com upload --product pve --dist $(DEB_DISTRIBUTION) + tar cf - $(DEBS) | ssh -X repoman@repo.proxmox.com upload --product pve --dist $(UPLOAD_DIST) $(BUILDDIR): src debian test common/src Cargo.toml rustfmt.toml Makefile .cargo/config.toml Fixup.pm rm -rf $(BUILDDIR) $(BUILDDIR).tmp -- 2.47.3