From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [45.144.208.40]) by lore.proxmox.com (Postfix) with ESMTPS id 3A5B01FF0BC for ; Thu, 29 Oct 2026 17:50:10 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id C1FD02161F; Thu, 29 Oct 2026 17:49:53 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.10.3 smtp.infra.comaite.com 030C762BFC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comaite.com; s=377A38C6-3A8D-11E5-A0EC-E97757B27CB3; t=1793292579; bh=Nmh3DQvzb6+rhH9AwBpo2wnUVXfN+AGPiWl//Inwevc=; h=From:To:Date:Message-ID:MIME-Version; b=hqNyoqFjYSeEcBHyJHYFFtGuJu4JIM1jWLZZRXWpLHkXEo/lFEspY3u1msgK80u3G HB7p01v7UjytcqzWitaGRVOziL4J5TtnxApymIlumdk0bxvSLZtoCCw0tSJ1OnXDJW Pv41VAw7t5N8BbGvAAA/V4D45of0ckoPAOQDkCuMEOSUiTqmkgZfooDkn/pYQHXer9 oJdDfT8sidq9Yj+MZoSLCLXEcd5K4qJCiMUBHSReeBKO89f183dKqJGu0iTVWmWwi+ WSSAZJ5D5yAoNru7Exx4eh1oVGg+e0mRXmiK0dyJYCbb0e6Dk2Cs81RUjJE44h0up+ jUzGj1cwLH1Pg== From: =?UTF-8?q?R=C3=A9mi=20PAETA?= To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 0/2] fix #6490: network: bridge fdb entries on nic hotplug Date: Thu, 29 Oct 2026 17:49:37 +0100 Message-ID: <20261029164939.1278135-1-remi.paeta@comaite.com> X-Mailer: git-send-email 2.47.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-SPAM-LEVEL: Spam detection results: 0 AWL 0.600 Adjusted score from AWL reputation of From: address DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain DMARC_PASS -0.1 DMARC pass policy SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: LLGN2CVXW3OBKVSVA7DAS4RGXCMDPKYK X-Message-ID-Hash: LLGN2CVXW3OBKVSVA7DAS4RGXCMDPKYK X-MailFrom: remi.paeta@comaite.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Thank you Gabriel and Fiona for your feedback on v1! This v2 takes it into account. On bridges with MAC learning disabled, hotplugged or re-plugged NICs get no forwarding database entries, so the guest loses connectivity on that NIC, and a later live migration fails when deleting the missing entries. v1: https://lore.proxmox.com/pve-devel/20261013095852.2586609-1-remi.paeta@comaite.com/ Changes since v1, following your feedback: - new first patch: only warn when deleting the entries fails at the end of a migration, instead of failing the migration after the VM state was transferred - only warn when adding the entries fails after plugging the NIC, so the configuration stays in sync with the running VM - only add the entries on hotplug if the NIC has a bridge, to not warn about NICs without one Note that with the synchronous config update of the web UI, such a warning only ends up in the syslog, as there is no task log. Tested on a Linux bridge with bridge-disable-mac-learning, with a failure of 'bridge fdb' injected where noted: - toggling the firewall of a NIC and hotplugging a NIC: entries added, connectivity kept - same with an injected failure: warning, configuration updated (v1 failed the update and left the new value pending, while the NIC was already re-plugged) - live migration with missing entries: warnings, migration succeeds, entries re-added on the target on resume, no QEMU left on the source (without the first patch, the VM stayed paused and locked on the target) Rémi PAETA (2): network: do not fail on missing bridge fdb entries when migrating fix #6490: network: add bridge fdb entries when hotplugging a nic src/PVE/QemuServer.pm | 8 ++++++++ src/PVE/QemuServer/Network.pm | 3 ++- 2 files changed, 10 insertions(+), 1 deletion(-) -- 2.47.3