From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate001.proxmox.com (gate001.proxmox.com [IPv6:2a0f:8001:1:32::40]) by lore.proxmox.com (Postfix) with ESMTPS id 5286F1FF0BC for ; Thu, 29 Oct 2026 13:09:17 +0100 (CET) Received: from gate001.proxmox.com (localhost.localdomain [127.0.0.1]) by gate001.proxmox.com (Proxmox) with ESMTP id 7C4E2216C5; Thu, 29 Oct 2026 13:08:28 +0100 (CET) From: Fiona Ebner To: pve-devel@lists.proxmox.com Subject: [PATCH qemu-server v2 7/7] clone disk: bump timeout for querying volume sizes to 1 minute Date: Thu, 29 Oct 2026 13:06:58 +0100 Message-ID: <20261029120811.107814-8-f.ebner@proxmox.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20261029120811.107814-1-f.ebner@proxmox.com> References: <20261029120811.107814-1-f.ebner@proxmox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Bm-Milter-Handled: 55990f41-d878-4baa-be0a-ee34c49e34d2 X-Bm-Transport-Timestamp: 1793275701137 X-SPAM-LEVEL: Spam detection results: 0 AWL 0.327 Adjusted score from AWL reputation of From: address DMARC_MISSING 0.1 Missing DMARC policy KAM_DMARC_STATUS 0.01 Test Rule for DKIM or SPF Failure with Strict Alignment (newer systems) RCVD_IN_DNSWL_MED -2.3 Sender listed at https://www.dnswl.org/, medium trust SPF_HELO_NONE 0.001 SPF: HELO does not publish an SPF Record SPF_PASS -0.001 SPF: sender matches SPF record Message-ID-Hash: HP7QOKAFLVNMT4WG6CLF4WVD5PDTUMOG X-Message-ID-Hash: HP7QOKAFLVNMT4WG6CLF4WVD5PDTUMOG X-MailFrom: f.ebner@proxmox.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list List-Id: Proxmox VE development discussion List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Since commit "fix #8209: clone disk: do not ignore failure to query size of target", failure to query the size of the target volume after clone is no longer quietly ignored. Bump the timeout to reduce the likelihood of harmless timeouts causing a warning. Print a message to communicate that the query is happening to the user. For consistency, also bump the timeout when querying the source volume. Clone might involve multiple disks and it could be a lot of wasted work if the whole operation is aborted because of reaching the timeout when querying the size. Signed-off-by: Fiona Ebner --- Changes in v2: * Use 'clone' in log message for consistency and triple dots. * Also bump timeout for querying source volumes. src/PVE/QemuServer.pm | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm index 636a5602..e1a0ad2f 100644 --- a/src/PVE/QemuServer.pm +++ b/src/PVE/QemuServer.pm @@ -7945,13 +7945,15 @@ sub clone_disk { } elsif ($dst_drivename eq 'efidisk0') { $size = $efisize or die "internal error - need to specify EFI disk size\n"; } elsif ($dst_drivename eq 'tpmstate0') { - $size = get_tpmstate_size($drive->{file}, $storecfg); + print "querying size of source volume '$drive->{file}'...\n"; + $size = get_tpmstate_size($drive->{file}, $storecfg, 60); } else { clone_disk_check_io_uring( $vmid, $drive, $storecfg, $src_storeid, $storeid, $use_drive_mirror, ); - $size = PVE::Storage::volume_size_info($storecfg, $drive->{file}, 10); + print "querying size of source volume '$drive->{file}'...\n"; + $size = PVE::Storage::volume_size_info($storecfg, $drive->{file}, 60); die "unable to query size of volume '$drive->{file}'\n" if !$size; } $source->{size} = $size; @@ -7988,7 +7990,8 @@ sub clone_disk { } my $result = {}; - my $size = eval { PVE::Storage::volume_size_info($storecfg, $newvolid, 10) }; + print "querying size of target volume '$newvolid' after clone...\n"; + my $size = eval { PVE::Storage::volume_size_info($storecfg, $newvolid, 60) }; my $err = $@; $err = "no size in result" if !$err && !$size; if ($err) { -- 2.47.3